From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Alex Vandiver <alexmv@dropbox.com>, git@vger.kernel.org
Subject: Re: [RFC] Reporting index properties
Date: Fri, 06 Oct 2017 13:02:12 +0900 [thread overview]
Message-ID: <xmqqvajsyldn.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20171006031303.GB134987@aiede.mtv.corp.google.com> (Jonathan Nieder's message of "Thu, 5 Oct 2017 20:13:03 -0700")
Jonathan Nieder <jrnieder@gmail.com> writes:
> Aside: git-update-index(1) says
>
> Version 4 is relatively young (first released in 1.8.0 in
> October 2012).
>
> My first reaction is to wonder if it is time to introduce a config
> option to use index format version 4 by default, since after 5 years
> it is not relatively young any more.
>
> My second reaction is to notice that the index.version configuration
> already exists. Probably git-update-index(1) ought to point to it.
Both good points.
> JGit still doesn't support index format 4, so 4 is still not a good
> default for `index.version` for a user that hasn't explicitly
> configured it, but the moment JGit gains that support I think it will
> be. :)
After reading ce_write_entry(), I tend to agree. v4 is the first
one that loses the alignment padding, which made sense back when we
mmap(2)ed the index file and read from it directly without the
ondisk-vs-incore conversion, but that stopped to be the case several
years ago.
I find it interesting to find that the recently proposed design for
reftable uses the same "common prefix compression from the previous
name" trick, even though index v4 does not have any resync point
like reftable does.
prev parent reply other threads:[~2017-10-06 4:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 23:39 [RFC] Reporting index properties Alex Vandiver
2017-10-06 0:43 ` Junio C Hamano
2017-10-06 0:47 ` Alex Vandiver
2017-10-06 2:39 ` Junio C Hamano
2017-10-06 19:26 ` Alex Vandiver
2017-10-06 3:13 ` Jonathan Nieder
2017-10-06 4:02 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqvajsyldn.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=alexmv@dropbox.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.