All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Brandon Williams <bmwill@google.com>
Cc: Valery Tolstov <me@vtolstov.org>,
	git@vger.kernel.org, sbeller@google.com
Subject: Re: [PATCH v3 2/2] submodule--helper.c: remove duplicate code
Date: Fri, 10 Mar 2017 11:42:50 -0800	[thread overview]
Message-ID: <xmqqvargyl39.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170309181837.GF153031@google.com> (Brandon Williams's message of "Thu, 9 Mar 2017 10:18:37 -0800")

Brandon Williams <bmwill@google.com> writes:

> On 03/09, Valery Tolstov wrote:
>> Remove code fragment from module_clone that duplicates functionality
>> of connect_work_tree_and_git_dir in dir.c
>> 
>> Signed-off-by: Valery Tolstov <me@vtolstov.org>
>
> Looks good.

I'll queue with your Reviewed-by: added.

If sb/checkout-recurse-submodules is going to be rerolled, I'd
appreciate if it includes this patch inserted at an appropriate
place in the series, instead of me having to remember re-applying
this patch every time it happens.

Thanks.

  reply	other threads:[~2017-03-10 19:43 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-08 17:44 [PATCH] submodule--helper.c: remove duplicate code me
2017-03-08 18:53 ` Stefan Beller
2017-03-08 19:59   ` Valery Tolstov
2017-03-08 20:25     ` Stefan Beller
2017-03-08 23:05       ` Valery Tolstov
2017-03-08 23:15         ` Stefan Beller
2017-03-08 23:24           ` Junio C Hamano
2017-03-08 23:34             ` Stefan Beller
2017-03-09  0:03       ` [PATCH v2 0/2] Remove duplicate code from module_clone() Valery Tolstov
2017-03-09  0:03         ` [PATCH v2 1/2] connect_work_tree_and_git_dir: safely create leading directories Valery Tolstov
2017-03-09  0:03         ` [PATCH v2 2/2] submodule--helper.c: remove duplicate code Valery Tolstov
2017-03-09  0:38           ` Brandon Williams
2017-03-09  1:27             ` [PATCH v3 0/2] Remove duplicate code from module_clone() Valery Tolstov
2017-03-09  1:27               ` [PATCH v3 1/2] connect_work_tree_and_git_dir: safely create leading directories Valery Tolstov
2017-03-09  1:27               ` [PATCH v3 2/2] submodule--helper.c: remove duplicate code Valery Tolstov
2017-03-09 18:18                 ` Brandon Williams
2017-03-10 19:42                   ` Junio C Hamano [this message]
2017-03-10 19:49                     ` Stefan Beller
2017-03-10 20:40                       ` Junio C Hamano
2017-03-10 20:48                         ` Stefan Beller
2017-03-09 22:54                 ` Valery Tolstov
2017-03-09  0:28         ` [PATCH v2 0/2] Remove duplicate code from module_clone() Brandon Williams
2017-03-09  0:56           ` Valery Tolstov
2017-03-09 18:19             ` Brandon Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqvargyl39.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=bmwill@google.com \
    --cc=git@vger.kernel.org \
    --cc=me@vtolstov.org \
    --cc=sbeller@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.