From: Junio C Hamano <gitster@pobox.com>
To: Robert Dailey <rcdailey.lists@gmail.com>
Cc: Git <git@vger.kernel.org>
Subject: Re: git add without whitespace
Date: Tue, 31 May 2016 09:16:21 -0700 [thread overview]
Message-ID: <xmqqvb1u5hka.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAHd499AreoaqfCVGi6XiatiWQMzf+KqL=a+f3D8u53dNkg0tiQ@mail.gmail.com> (Robert Dailey's message of "Tue, 31 May 2016 10:03:01 -0500")
Robert Dailey <rcdailey.lists@gmail.com> writes:
> - Splitting whitespace & real changes to two commits is probably
> superfluous; my original goal was to make diffing the actual changes
> easier, but since 'git diff -w' exists this is moot.
Doing "whitespace clean-up" in a separate preparatory patch _is_ a
good practice. I do not think either approach makes it harder to
do. After all, if you had a real change on the same line that you
dropped a broken whitespace, e.g. (end-of-line shown with '$')
- if (i==1) { $
+ if (j == 2) {$
both approaches would add the updated line.
The wsadd is about protecting _me_ from introducing new whitespace
breakages, not about helping me when fixing existing whitespace
breakages. So from that point of view, that may not fit well to
what you are trying to do.
next prev parent reply other threads:[~2016-05-31 16:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 15:26 git add without whitespace Robert Dailey
2016-05-30 19:06 ` Junio C Hamano
2016-05-30 19:50 ` Robert Dailey
2016-05-30 22:00 ` Junio C Hamano
2016-05-31 15:03 ` Robert Dailey
2016-05-31 16:16 ` Junio C Hamano [this message]
2016-05-31 15:59 ` Christian Neukirchen
2016-05-31 16:27 ` demerphq
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqvb1u5hka.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=rcdailey.lists@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.