All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: Duy Nguyen <pclouds@gmail.com>, Ed Avis <eda@waniasset.com>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: Log messages beginning # and git rebase -i
Date: Wed, 29 Jul 2015 08:54:48 -0700	[thread overview]
Message-ID: <xmqqvbd39cxj.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <vpq8u9zjgzl.fsf@anie.imag.fr> (Matthieu Moy's message of "Wed, 29 Jul 2015 14:17:02 +0200")

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:

> Duy Nguyen <pclouds@gmail.com> writes:
>
>> On Wed, Jul 29, 2015 at 12:48 AM, Matthieu Moy
>> <Matthieu.Moy@grenoble-inp.fr> wrote:
>>>> If the user wants whatever she types in the resulting commit
>>>> literally, there is the "--cleanup=<choice>" option, no?
>>>
>>> $ GIT_EDITOR=touch git commit --cleanup=verbatim
>>> [detached HEAD 1b136a7] # Please enter the commit message for your
>>> changes. Lines starting # with '#' will be kept; you may remove
>>> them yourself if you want
>>> to. # An empty message aborts the commit. # HEAD detached from
>>> 5e70007 # Changes to be committed: # modified: foo.txt # # Changes
>>> not staged for commit
>>> : #     modified:   foo.txt # # Untracked files: #      last-synchro.txt #
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> You really don't want that in day-to-day use.

I do not quite follow this example.

The user said "I'll be responsible for cleaning up" by giving the
option.  It is up to the user to use an editor that is something a
bit more intelligent than "touch" to remove the instructional
comments meant for humans after reading them.

> 2) Modify Git to add scissors by default, and use --cleanup=scissors by
>    default.

I just did "$ git commit --amend --cleanup=scissors" (with and
without --amend) and it seems to do exactly that ;-).

  parent reply	other threads:[~2015-07-29 15:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-27 11:38 Log messages beginning # and git rebase -i Ed Avis
2015-07-27 23:25 ` Eric Sunshine
2015-07-28  0:53   ` Duy Nguyen
2015-07-28  9:51   ` Ed Avis
2015-07-28 15:25     ` Matthieu Moy
2015-07-28 16:30       ` Junio C Hamano
2015-07-28 16:40         ` Ed Avis
2015-07-28 17:48         ` Matthieu Moy
2015-07-28 18:44           ` Junio C Hamano
2015-07-29 10:17             ` Matthieu Moy
2015-07-29 10:19               ` Ed Avis
2019-04-22 10:05             ` [PATCH] allow commentChars in commit messages Corentin BOMPARD
2015-07-29 10:47           ` Log messages beginning # and git rebase -i Duy Nguyen
2015-07-29 12:17             ` Matthieu Moy
2015-07-29 12:47               ` Duy Nguyen
2015-07-29 15:54               ` Junio C Hamano [this message]
2015-07-29 16:03                 ` Matthieu Moy
2015-07-29 17:02                   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqvbd39cxj.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=Matthieu.Moy@grenoble-inp.fr \
    --cc=eda@waniasset.com \
    --cc=git@vger.kernel.org \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.