From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Torsten Bögershausen" <tboegi@web.de>, git@vger.kernel.org
Subject: Re: [PATCH] t3910: show failure of core.precomposeunicode with decomposed filenames
Date: Tue, 29 Apr 2014 10:12:52 -0700 [thread overview]
Message-ID: <xmqqvbtskqjv.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140428161630.GA9435@sigill.intra.peff.net> (Jeff King's message of "Mon, 28 Apr 2014 12:16:31 -0400")
Jeff King <peff@peff.net> writes:
> This patch just adds a test to demonstrate the breakage.
> Some possible fixes are:
>
> 1. Tell everyone that NFD in the git repo is wrong, and
> they should make a new commit to normalize all their
> in-repo files to be precomposed.
>
> This is probably not the right thing to do, because it
> still doesn't fix checkouts of old history. And it
> spreads the problem to people on byte-preserving
> filesystems (like ext4), because now they have to start
> precomposing their filenames as they are adde to git.
Hmm, have we taught the "compare precomposed" for codepaths that
compare two trees and a tree and the index, too? Otherwise, we
would have the same issue with commits in the old history.
Do we have a similar issue for older commit in a history under
"ignore-case" as well?
next prev parent reply other threads:[~2014-04-29 17:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 16:16 [PATCH] t3910: show failure of core.precomposeunicode with decomposed filenames Jeff King
2014-04-28 19:17 ` Junio C Hamano
2014-04-28 19:35 ` Jeff King
2014-04-28 19:52 ` Torsten Bögershausen
2014-04-28 20:03 ` Jeff King
2014-04-28 20:49 ` Torsten Bögershausen
2014-04-29 3:23 ` Jeff King
2014-04-29 7:39 ` Torsten Bögershausen
2014-04-29 3:15 ` Jeff King
2014-04-29 17:12 ` Junio C Hamano [this message]
2014-04-29 18:02 ` Jeff King
2014-04-29 18:49 ` Junio C Hamano
2014-04-29 19:46 ` Jeff King
2014-04-30 14:57 ` Torsten Bögershausen
2014-05-04 12:04 ` Torsten Bögershausen
2014-05-04 6:13 ` Torsten Bögershausen
2014-05-05 21:46 ` Jeff King
2014-05-06 10:11 ` Erik Faye-Lund
2014-05-07 19:16 ` Torsten Bögershausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqvbtskqjv.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.