From: Junio C Hamano <gitster@pobox.com>
To: Johan Herland <johan@herland.net>
Cc: Joachim Breitner <mail@joachim-breitner.de>,
Git mailing list <git@vger.kernel.org>
Subject: Re: git-note -C changes commit type?
Date: Tue, 11 Feb 2014 16:06:46 -0800 [thread overview]
Message-ID: <xmqqvbwlnqi1.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CALKQrgcM7JpZCk4amjo_rwg5uuuWNg-5yd1NXB5p7EtrU9WBGg@mail.gmail.com> (Johan Herland's message of "Wed, 12 Feb 2014 00:52:51 +0100")
Johan Herland <johan@herland.net> writes:
> There is currently no way the "git notes" commands will allow you to
> store the 3d7de37 commit object directly as a note. There is also
> (AFAICS) no easy workaround (git fast-import could've been a
> workaround if it did not already require the first N/notemodify
> argument to be a blob object). The best alternative, off the top of my
> head, would be to write your own program using the notes.h API to
> manipulate the notes tree directly (or - suboptimally - use other
> low-level Git operations to do the same).
Even worse. I do not think such a non-blob object in the notes tree
does not participate in the reachability at all, so you won't be
able to fetch "refs/notes/whatever" and expect to get a useful
result. I do not think storing the raw bits of commit object as a
blob in the notes tree is useful behaviour, either. The command
probably should refuse to get anything non-blob via that option.
Perhaps the notes entry should just note the object name of whatever
commit it wants to refer to in a *blob*?
next prev parent reply other threads:[~2014-02-12 0:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 17:23 git-note -C changes commit type? Joachim Breitner
2014-02-11 23:52 ` Johan Herland
2014-02-12 0:06 ` Junio C Hamano [this message]
2014-02-12 5:16 ` Kyle J. McKay
2014-02-12 9:50 ` Johan Herland
2014-02-12 9:54 ` [PATCH] notes: Disallow reusing non-blob as a note object Johan Herland
2014-02-14 15:19 ` Eric Sunshine
2014-02-14 16:19 ` Junio C Hamano
2014-02-12 8:53 ` git-note -C changes commit type? Joachim Breitner
2014-02-12 10:26 ` Johan Herland
2014-02-12 10:33 ` Joachim Breitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqvbwlnqi1.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=johan@herland.net \
--cc=mail@joachim-breitner.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.