All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Tejun Heo <tj@kernel.org>, Git Mailing List <git@vger.kernel.org>,
	Jeff King <peff@peff.net>
Subject: Re: [RFC PATCH 2/1] Make request-pull able to take a refspec of form local:remote
Date: Fri, 24 Jan 2014 12:16:24 -0800	[thread overview]
Message-ID: <xmqqvbx9qgo7.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CA+55aFyN7WWAF6pGfP+0j29nf6ETao0J5sUu+5UDaXUYC9_Geg@mail.gmail.com> (Linus Torvalds's message of "Thu, 23 Jan 2014 15:56:14 -0800")

Linus Torvalds <torvalds@linux-foundation.org> writes:

> So I don't actually think anybody should need to be retrained, or
> "always use the local:remote" syntax. The local:remote syntax exists
> only for that special insane case where you used (the same)
> local:remote syntax to push out a branch under a different name.
>
> [ And yeah, maybe that behavior is more common than I think, but even
> if it is, such behavior would always be among people who are *very*
> aware of the whole "local branch vs remote branch name is different"
> situation. ]

As the new default for "git push" would push to the same name, I
agree that people who are now forced to use local:remote syntax
would be the ones who know what they are doing [*1*].

So there are two remaining items, I think.

 - After creating a tags/for-linus signed tag and pushing it to
   tags/for-linus, asking request-pull to request that tag to be
   pulled seems to lose the tag message from the output.

 - Docs.


[Footnote]

*1* Not that it is always acceptable to break the existing users as
    long as they are clueful ones and they are given an escape hatch.
    But this time I know I won't be in the middle of firestorm like
    the one we had immediately after 1.6.0, as long as I keep the
    URL of the message I am responding to in the list archive ;-)

  reply	other threads:[~2014-01-24 20:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-23  0:06 [RFC PATCH 2/1] Make request-pull able to take a refspec of form local:remote Linus Torvalds
2014-01-23 19:43 ` Junio C Hamano
2014-01-23 19:57   ` Linus Torvalds
2014-01-23 22:58     ` Junio C Hamano
2014-01-23 23:56       ` Linus Torvalds
2014-01-24 20:16         ` Junio C Hamano [this message]
2014-01-29 23:34           ` Re* " Junio C Hamano
2014-01-30  0:16             ` brian m. carlson
2014-01-30  0:40             ` Linus Torvalds
2014-02-25 21:44               ` Junio C Hamano
2014-03-12 18:04                 ` Junio C Hamano
2014-03-12 23:18                   ` Eric Sunshine
2014-03-13 21:22                     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqvbx9qgo7.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=tj@kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.