All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Okhuomon Ajayi <okhuomonajayi54@gmail.com>
Cc: git@vger.kernel.org,  christian.couder@gmail.com,
	usmanakinyemi202@gmail.com,  siddharthasthana31@gmail.com,
	kaartic.sivaraam@gmail.com
Subject: Re: [Outreachy PATCH] delta-islands: use Q_() for island count
Date: Tue, 13 Oct 2026 13:33:53 -0700	[thread overview]
Message-ID: <xmqqwlrluyq6.fsf@gitster.g> (raw)
In-Reply-To: <CAFpMFfAQET2OvZB905cajvhSG6BS9t4zx5G6iGG6BUP_o8wUGQ@mail.gmail.com> (Okhuomon Ajayi's message of "Tue, 13 Oct 2026 20:44:12 +0100")

Okhuomon Ajayi <okhuomonajayi54@gmail.com> writes:

> On Tue, Oct 13, 2026 at 7:00 PM Junio C Hamano <gitster@pobox.com> wrote:
>
>> I am not sure of the value in this, though.  You certainly do not
>> mean to say that you updated all of the ones that you found with the
>> above.  You are not inviting others to do the same grep and "fix"
>> any of the hits, as the pattern gives too many false positives
>> (i.e., not all %d are about number of things, like the line number a
>> parser has found the error it is reporting at), and without warning
>> that, it would not be helpful to these others.
>
> You are right, I will remove it from the commit message and send a v2.

I think is is common to have such a "not quite suited for the
permanent commit log message, but may help reviewers and others who
are reading the patch while it is still being worked on" material
under the three-dash line below your sign-off.



>
>> The change itself looks sensible to me.
>
> Thank you for the review.
>
> Okhuomon
>
> Okhuomon

  reply	other threads:[~2026-10-13 20:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-13 14:25 [Outreachy] Introduction: Okhuomon Ajayi, microproject in delta-islands.c Okhuomon Ajayi
2026-10-13 16:49 ` [Outreachy PATCH] delta-islands: use Q_() for island count Okhuomon Ajayi
2026-10-13 18:00   ` Junio C Hamano
2026-10-13 19:44     ` Okhuomon Ajayi
2026-10-13 20:33       ` Junio C Hamano [this message]
2026-10-13 20:30   ` [Outreachy PATCH v2] " Okhuomon Ajayi
2026-10-13 20:13 ` [Outreachy] Introduction: Okhuomon Ajayi, microproject in delta-islands.c Usman Akinyemi
2026-10-13 20:32   ` Okhuomon Ajayi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqwlrluyq6.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=kaartic.sivaraam@gmail.com \
    --cc=okhuomonajayi54@gmail.com \
    --cc=siddharthasthana31@gmail.com \
    --cc=usmanakinyemi202@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.