From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: "Torsten Bögershausen" <tboegi@web.de>,
"SZEDER Gábor" <szeder.dev@gmail.com>,
"Amisha Chhajed" <amishhhaaaa@gmail.com>,
git@vger.kernel.org, avarab@gmail.com, peff@peff.net,
stolee@gmail.com
Subject: Re: [PATCH v4 1/1] help: cleanup the contruction of keys_uniq
Date: Wed, 11 Mar 2026 14:50:56 -0700 [thread overview]
Message-ID: <xmqqwlzikpbz.fsf@gitster.g> (raw)
In-Reply-To: <CAPig+cQ+HLjBjtGA9s_ZYYWNjRj_Bax5CkJFa98a-z=LoyEFoQ@mail.gmail.com> (Eric Sunshine's message of "Wed, 11 Mar 2026 17:39:39 -0400")
Eric Sunshine <sunshine@sunshineco.com> writes:
>> sed \
>> -E -e "
>> ...
>> " human |
>> sort -u
>
> For what it's worth, line folding capability was added to
> check-non-portable-shell.pl by a0a630192d (t/check-non-portable-shell:
> detect "FOO=bar shell_func", 2018-07-13), so it does correctly detect
> the errant -E in this example.
Ah, thanks for correcting me.
But "sed -n -i -e '/.../p'" would not catch "-i", and that is not
all that unlikely, I suspect.
next prev parent reply other threads:[~2026-03-11 21:50 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-12 4:10 [PATCH 0/2] clean leftover calls to string_list_remove_duplicates Amisha Chhajed
2026-02-12 4:10 ` [PATCH 1/2] sparse-checkout: use string_list_sort_u Amisha Chhajed
2026-02-12 19:30 ` Junio C Hamano
2026-02-12 4:10 ` [PATCH 2/2] help: ensure &keys_uniq follows sort -u Amisha Chhajed
2026-02-12 19:58 ` Junio C Hamano
2026-02-12 21:29 ` Amisha Chhajed
2026-02-12 21:37 ` Junio C Hamano
2026-02-13 3:37 ` [PATCH v2 1/2] sparse-checkout: use string_list_sort_u Amisha Chhajed
2026-02-13 3:37 ` [PATCH v2 2/2] help: cleanup the contruction of keys_uniq Amisha Chhajed
2026-02-13 4:30 ` Junio C Hamano
2026-02-13 5:02 ` Eric Sunshine
2026-02-13 16:57 ` Junio C Hamano
2026-02-21 16:28 ` Amisha Chhajed
2026-02-21 16:23 ` [PATCH v3 1/2] sparse-checkout: use string_list_sort_u Amisha Chhajed
2026-02-21 16:23 ` [PATCH v3 2/2] help: cleanup the contruction of keys_uniq Amisha Chhajed
2026-02-22 5:05 ` Junio C Hamano
2026-02-22 9:47 ` Amisha Chhajed
2026-02-26 16:45 ` Junio C Hamano
2026-02-28 10:51 ` Amisha Chhajed
2026-03-02 16:06 ` Junio C Hamano
2026-02-22 2:44 ` [PATCH v3 1/2] sparse-checkout: use string_list_sort_u Junio C Hamano
2026-02-28 10:46 ` [PATCH v4 0/1] Make keys_uniq stop depending on sort of keys_uniq Amisha Chhajed
2026-02-28 10:46 ` [PATCH v4 1/1] help: cleanup the contruction " Amisha Chhajed
2026-03-02 16:04 ` Junio C Hamano
2026-03-11 19:48 ` Amisha Chhajed
2026-03-11 21:11 ` Junio C Hamano
2026-03-11 21:39 ` Eric Sunshine
2026-03-11 21:50 ` Junio C Hamano [this message]
2026-03-11 21:54 ` Eric Sunshine
2026-03-11 19:24 ` [PATCH v5] " Amisha Chhajed
2026-03-11 19:46 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwlzikpbz.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=amishhhaaaa@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=stolee@gmail.com \
--cc=sunshine@sunshineco.com \
--cc=szeder.dev@gmail.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.