All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Patrick Steinhardt <ps@pks.im>,
	 Karthik Nayak <karthik.188@gmail.com>,
	git@vger.kernel.org,  Phillip Wood <phillip.wood123@gmail.com>
Subject: Re: [PATCH v2 1/3] t/unit-tests: update clar to 39f11fe
Date: Thu, 08 Jan 2026 21:46:15 +0900	[thread overview]
Message-ID: <xmqqwm1sff1k.fsf@gitster.g> (raw)
In-Reply-To: <20260107074000.GA102520@coredump.intra.peff.net> (Jeff King's message of "Wed, 7 Jan 2026 02:40:00 -0500")

Jeff King <peff@peff.net> writes:

>> The alternative would be to make this `cl_fail(...)` instead, but to the
>> best of my knowledge this isn't even a valid construct.
>
> It is valid; that's how we define BUG(), for example.

Thanks.  I was wondering how that thing was working after seeing
Patrick's message ;-).

> There are other options like GNU's "## __VA_ARGS__", but I think eating
> the format argument with the "..." is the only portable way, at least
> for standard versions we'd support. I think C23 added __VA_OPT__.
>
> -Peff

  reply	other threads:[~2026-01-08 12:46 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-05 12:57 [PATCH 0/2] Update clar for improved integer handling Patrick Steinhardt
2025-12-05 12:57 ` [PATCH 1/2] t/unit-tests: update clar to 39f11fe Patrick Steinhardt
2025-12-05 18:40   ` Jeff King
2025-12-06 11:39     ` Patrick Steinhardt
2025-12-06  5:27   ` Junio C Hamano
2025-12-06 11:46     ` Patrick Steinhardt
2025-12-05 12:57 ` [PATCH 2/2] t/unit-tests: demonstrate use of integer comparison assertions Patrick Steinhardt
2025-12-06 11:47 ` [PATCH v2 0/3] Update clar for improved integer handling Patrick Steinhardt
2025-12-06 11:47   ` [PATCH v2 1/3] t/unit-tests: update clar to 39f11fe Patrick Steinhardt
2026-01-06 10:59     ` Karthik Nayak
2026-01-06 11:16       ` Patrick Steinhardt
2026-01-06 16:28         ` Karthik Nayak
2026-01-07  7:40         ` Jeff King
2026-01-08 12:46           ` Junio C Hamano [this message]
2025-12-06 11:47   ` [PATCH v2 2/3] t/unit-tests: demonstrate use of integer comparison assertions Patrick Steinhardt
2025-12-06 11:47   ` [PATCH v2 3/3] gitattributes: disable blank-at-eof errors for clar test expectations Patrick Steinhardt
2026-01-06 11:01   ` [PATCH v2 0/3] Update clar for improved integer handling Karthik Nayak
2026-01-06 11:16     ` Patrick Steinhardt
2026-01-07  3:53       ` Junio C Hamano
2026-01-07  7:01         ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqwm1sff1k.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=karthik.188@gmail.com \
    --cc=peff@peff.net \
    --cc=phillip.wood123@gmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.