From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: Olamide Caleb Bello <belkid98@gmail.com>,
git@vger.kernel.org,
Christian Couder <christian.couder@gmail.com>,
Usman Akinyemi <usmanakinyemi202@gmail.com>,
Kaartic Sivaraam <kaartic.sivaraam@gmail.com>,
Taylor Blau <me@ttaylorr.com>,
Karthik Nayak <karthik.188@gmail.com>
Subject: Re: [Outreachy PATCH v2] environment: move "core.attributesFile" into repo-setting
Date: Tue, 06 Jan 2026 07:28:25 +0900 [thread overview]
Message-ID: <xmqqwm1vk83a.fsf@gitster.g> (raw)
In-Reply-To: <3947f777-e08a-4c17-81e3-c4711fe666a0@gmail.com> (Phillip Wood's message of "Mon, 5 Jan 2026 15:00:28 +0000")
Phillip Wood <phillip.wood123@gmail.com> writes:
> On 05/01/2026 14:23, Phillip Wood wrote:
>>
>> It is quite common that moving from parsing config settings eagerly by
>> calling repo_config() at startup to parsing them lazily via 'stuct
>> repo_settings' causes regressions like this. We really should find a way
>> to address that before moving more settings into 'struct repo_settings'
>
> See
> https://lore.kernel.org/git/d61c966b-61ae-4ba9-b983-c8dab6e2c292@gmail.com
> for some discussion about a possible solution.
Nice, but I suspect it would be an improvement already without
passing repository instance via git_default_config() and instead
have the code use the_repository; it is even possible not to have
any repository when the callchain executes.
next prev parent reply other threads:[~2026-01-05 22:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-18 8:30 [Outreachy PATCH] environment: move "core.attributesFile" into repo-setting Olamide Caleb Bello
2025-12-18 17:31 ` Bello Olamide
2026-01-02 8:01 ` Bello Olamide
2026-01-02 8:49 ` Karthik Nayak
2026-01-02 8:48 ` Karthik Nayak
2026-01-02 11:26 ` Bello Olamide
2026-01-02 16:32 ` [Outreachy PATCH v2] " Olamide Caleb Bello
2026-01-05 11:09 ` Karthik Nayak
2026-01-05 11:39 ` Bello Olamide
2026-01-05 14:23 ` Phillip Wood
2026-01-05 15:00 ` Phillip Wood
2026-01-05 22:28 ` Junio C Hamano [this message]
2026-01-06 9:33 ` Bello Olamide
2026-01-06 13:44 ` Bello Olamide
2026-01-07 10:26 ` Phillip Wood
2026-01-07 14:18 ` Phillip Wood
2026-01-07 15:33 ` Bello Olamide
2026-01-06 8:09 ` Bello Olamide
2026-01-05 22:24 ` Junio C Hamano
2026-01-07 10:17 ` Phillip Wood
2026-01-06 8:08 ` Bello Olamide
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwm1vk83a.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=belkid98@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=kaartic.sivaraam@gmail.com \
--cc=karthik.188@gmail.com \
--cc=me@ttaylorr.com \
--cc=phillip.wood123@gmail.com \
--cc=usmanakinyemi202@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.