All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Dec 2025, #02)
Date: Wed, 10 Dec 2025 21:00:51 +0900	[thread overview]
Message-ID: <xmqqwm2uh7gs.fsf@gitster.g> (raw)
In-Reply-To: <CAOLa=ZTAdpRurHGiBj2rQhtBJxuWPz4__2Q1LgJ4rC2qAdL=0g@mail.gmail.com> (Karthik Nayak's message of "Wed, 10 Dec 2025 02:04:48 -0800")

Karthik Nayak <karthik.188@gmail.com> writes:

>>>>  Expecting a (hopefully small and final) reroll.
>>>>  cf. <CAOLa=ZQ-O7V9qHbgeuQ78R1bHGDmGEM6fP5Kr9aC0AfvSF8MZA@mail.gmail.com>
>>>>  source: <20251121-fix-tags-not-fetching-v8-0-23b53a8a8334@gmail.com>
>>>
>>> The only change needed from the last review was a typo. I think we should be
>>> good as is.
>>
>> Meaning that we prefer to leave the typo in, or just we won't die
>> with a known typo?
>
> The typo was in a comment in the tests, so I thought it wasn't worth
> re-rolling, but happy to do so.

I went back to the discussion to find that single typo and tweaked
it myself in my tree, so no need to resend.

Thanks.


diff --git c/t/t5510-fetch.sh w/t/t5510-fetch.sh
index a1ca4e1ac7..ce1c23684e 100755
--- c/t/t5510-fetch.sh
+++ w/t/t5510-fetch.sh
@@ -1628,7 +1628,7 @@ test_expect_success "backfill tags when providing a refspec" '
 	    test_commit fetch-me
 	) &&
 
-	# The "history" tag is backfilled eventhough we requested
+	# The "history" tag is backfilled even though we requested
 	# to only fetch HEAD
 	git -C target fetch origin HEAD:branch &&
 	git -C target tag -l >actual &&

  reply	other threads:[~2025-12-10 12:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-09 21:08 What's cooking in git.git (Dec 2025, #02) Junio C Hamano
2025-12-09 22:46 ` Karthik Nayak
2025-12-09 23:10   ` Junio C Hamano
2025-12-10 10:04     ` Karthik Nayak
2025-12-10 12:00       ` Junio C Hamano [this message]
2025-12-12 21:29         ` Karthik Nayak
2025-12-10  7:55 ` Kristoffer Haugsbakk
2025-12-10  9:20   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqwm2uh7gs.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=karthik.188@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.