From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Derrick Stolee <stolee@gmail.com>, git@vger.kernel.org
Subject: Re: What's cooking in git.git (Jan 2025, #06; Wed, 22)
Date: Sun, 02 Feb 2025 15:33:06 -0800 [thread overview]
Message-ID: <xmqqwme73ost.fsf@gitster.g> (raw)
In-Reply-To: <20250131233452.GB3544301@coredump.intra.peff.net> (Jeff King's message of "Fri, 31 Jan 2025 18:34:52 -0500")
Jeff King <peff@peff.net> writes:
>> Nice way to use extended context to show why the change makes sense.
>
> I've been tempted to support a:
>
> Diff-options: -U10
>
> trailer, but that is probably overkill and full of annoying corner
> cases.
Do you mean to embed it in the commit log trailer and upon seeing
it, the log family of commands add it to their setup_revisions()
invocation, thusly affecting things like "format-patch" and "show"?
As a reminder for a patch submitter (i.e., communicated by you who
wrote the commit to future you who will run format-patch for
submission), something locally maintained might be sufficient,
e.g. refs/notes/diffopts that is not shared by default, but still,
this hint probably wants to be per-path (ideally per-hunk).
But I think it will make it annoying if you forced those who fetched
from you to use "-U10" when they do "git show", as the choice would
be strongly affected by personal preference. And I certainly do not
want to see anything less benign than "-U10" silently forced upon me.
Thanks.
next prev parent reply other threads:[~2025-02-02 23:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-22 22:48 What's cooking in git.git (Jan 2025, #06; Wed, 22) Junio C Hamano
2025-01-23 0:36 ` Jeff King
2025-01-23 1:52 ` Junio C Hamano
2025-01-31 23:34 ` Jeff King
2025-01-31 23:39 ` Jeff King
2025-01-31 23:49 ` Junio C Hamano
2025-02-01 2:29 ` Jeff King
2025-02-02 23:39 ` Junio C Hamano
2025-02-03 13:51 ` Junio C Hamano
2025-02-04 2:35 ` Jeff King
2025-02-02 18:09 ` D. Ben Knoble
2025-02-02 23:33 ` Junio C Hamano [this message]
2025-02-03 15:33 ` Jeff King
2025-01-23 0:38 ` Eric Sunshine
2025-01-23 1:53 ` Junio C Hamano
2025-01-23 17:36 ` Taylor Blau
2025-01-24 6:07 ` Patrick Steinhardt
2025-01-24 12:55 ` Toon Claes
2025-01-24 17:05 ` Junio C Hamano
2025-01-24 16:02 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwme73ost.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.