From: Junio C Hamano <gitster@pobox.com>
To: Elijah Newren <newren@gmail.com>
Cc: Jeff King <peff@peff.net>,
Elijah Newren via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Eric Sunshine <sunshine@sunshineco.com>,
Patrick Steinhardt <ps@pks.im>,
Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Subject: Re: [PATCH v2] fast-import: disallow more path components
Date: Wed, 04 Dec 2024 07:17:15 +0900 [thread overview]
Message-ID: <xmqqwmggbedw.fsf@gitster.g> (raw)
In-Reply-To: <CABPp-BGP8zrSzxcacTzLY-EuYAQW5EwyDGNAMh196udGN18fmg@mail.gmail.com> (Elijah Newren's message of "Tue, 3 Dec 2024 00:01:51 -0800")
Elijah Newren <newren@gmail.com> writes:
> On Sun, Dec 1, 2024 at 1:40 PM Jeff King <peff@peff.net> wrote:
>>
>> On Sat, Nov 30, 2024 at 01:09:29AM +0000, Elijah Newren via GitGitGadget wrote:
>>
>> > Changes since v1:
>> >
>> > * Moved the check to a higher level, as suggested by Peff.
>>
>> Thanks, the code change looks good. Is it worth tweaking one of the
>> tests to do "R innocent-path .git/evil"? Otherwise I don't think there's
>> any coverage of the file_change_cr() call at all.
>>
>> -Peff
>
> I would say yes, but since this patch too has made it to next and is
> marked for master, I'm kinda tempted to just leave it as-is...
It is perfectly OK to have a follow-up patch that adds a test or two
;-)
next prev parent reply other threads:[~2024-12-03 22:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 20:47 [PATCH] fast-import: disallow more path components Elijah Newren via GitGitGadget
2024-11-28 0:22 ` Junio C Hamano
2024-11-28 16:12 ` Jeff King
2024-11-30 1:09 ` [PATCH v2] " Elijah Newren via GitGitGadget
2024-12-01 21:40 ` Jeff King
2024-12-03 8:01 ` Elijah Newren
2024-12-03 21:06 ` [PATCH 2/1] t9300: test verification of renamed paths Jeff King
2024-12-03 22:22 ` Elijah Newren
2024-12-04 0:15 ` Junio C Hamano
2024-12-03 22:17 ` Junio C Hamano [this message]
2024-12-02 1:04 ` [PATCH v2] fast-import: disallow more path components Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwmggbedw.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=kristofferhaugsbakk@fastmail.com \
--cc=newren@gmail.com \
--cc=peff@peff.net \
--cc=ps@pks.im \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.