All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>
Cc: "Phillip Wood" <phillip.wood@dunelm.org.uk>,
	 "Johannes Sixt" <j6t@kdbg.org>,
	 "Git Mailing List" <git@vger.kernel.org>
Subject: Re: How dangerous is --committer-date-is-author-date these days?
Date: Mon, 30 Sep 2024 10:08:23 -0700	[thread overview]
Message-ID: <xmqqwmit83y0.fsf@gitster.g> (raw)
In-Reply-To: <93041214-4774-49eb-b8bd-24648134cded@app.fastmail.com> (Kristoffer Haugsbakk's message of "Mon, 30 Sep 2024 16:49:32 +0200")

"Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> writes:

> As a Git user, I don’t understand why some people want to fiddle with
> this field in rewrite operations.  It’s very hidden (apparently you have
> to use something like `git log --format=fuller` to reveal it).

FWIW, as a Git user, I don't, either.

It is justifiable for "rebase -i" to be aware of the option, merely
because the underlying "git am" had it.  I think "--ignore-date"
option falls into a similar bucket, but it is of lessor evil between
the two (at least I can see a legitimate reasoning behind use of
that option).

> I can’t speak for power users.  But regular users?  Well I see questions
> about being very deliberate about setting this field on rewrite
> operations on StackOverflow (at least one time).  But I can only guess
> *why* they are particular about it (this part is often not explained).
> And I don’t know if they know the true “spirit” behind the field.

Very nicely said.  There _might_ be a legitimate reason to futz with
the committer date, but I do not think of a good reason why it makes
sense to replace it with the author date.  They are separate fields
because they mean different things---your mention of "true spirit"
is spot-on.

> That option was added to git-am(1).  So not a rewrite operation.  Rather
> a “lie” (as it was documented on that commit).

Yes, I do not offhand see a reason why the option should exist.  I
won't be the person who says "no, it is valuable, do not touch it"
if somebody proposes to drop it (from all places) at a major version
boundary.

Thanks.


  reply	other threads:[~2024-09-30 17:08 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-28  6:59 How dangerous is --committer-date-is-author-date these days? Johannes Sixt
2024-09-28  9:49 ` Phillip Wood
2024-09-28 10:04   ` Phillip Wood
2024-09-30 14:49     ` Kristoffer Haugsbakk
2024-09-30 17:08       ` Junio C Hamano [this message]
2025-10-08 20:41       ` SZEDER Gábor
2025-10-08 19:45 ` [PATCH] doc: warn against --committer-date-is-author-date kristofferhaugsbakk
2025-10-09 13:46   ` Phillip Wood
2025-10-09 14:31     ` Kristoffer Haugsbakk
2025-10-09 20:47       ` Kristoffer Haugsbakk
2025-10-09 21:58         ` Junio C Hamano
2025-10-09 22:56           ` Kristoffer Haugsbakk
2025-10-09 21:41     ` Junio C Hamano
2025-10-09 21:57       ` Kristoffer Haugsbakk
2025-10-11  9:15   ` Johannes Sixt
2025-10-16 14:13     ` Kristoffer Haugsbakk
2025-10-16 15:12       ` Kristoffer Haugsbakk
2025-10-16 15:28       ` Johannes Sixt
2025-10-16 15:42         ` Kristoffer Haugsbakk
2025-10-16 16:23         ` Junio C Hamano
2025-11-19 16:27           ` Kristoffer Haugsbakk
2025-11-20 16:26   ` [PATCH v2] " kristofferhaugsbakk
2025-11-20 17:19     ` Johannes Sixt
2025-11-26 16:02     ` Phillip Wood
2025-11-27  6:30       ` Kristoffer Haugsbakk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqwmit83y0.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=j6t@kdbg.org \
    --cc=kristofferhaugsbakk@fastmail.com \
    --cc=phillip.wood@dunelm.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.