From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Derrick Stolee <stolee@gmail.com>
Subject: Re: [PATCH] scalar: add --no-tags option
Date: Fri, 06 Sep 2024 08:13:02 -0700 [thread overview]
Message-ID: <xmqqwmjoyfwh.fsf@gitster.g> (raw)
In-Reply-To: <58ca5257-2e56-830c-c85f-79e4c9e80858@gmx.de> (Johannes Schindelin's message of "Fri, 6 Sep 2024 09:23:49 +0200 (CEST)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> None of these suggestions, in isolation or in conjunction, seem big enough
> to me to warrant a new iteration; I just offer them here in case you want
> to iterate on the patch. If you want to keep the patch as-is, I am totally
> on board with that.
Everything other than "prefer repeated use of -C instead of a single
subshell in there" (which I think worsens readability, even though
it may save one process), I agree with your suggestions.
Thanks.
next prev parent reply other threads:[~2024-09-06 15:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 14:13 [PATCH] scalar: add --no-tags option Derrick Stolee via GitGitGadget
2024-09-05 16:12 ` Junio C Hamano
2024-09-05 18:25 ` Junio C Hamano
2024-09-06 7:23 ` Johannes Schindelin
2024-09-06 15:13 ` Junio C Hamano [this message]
2024-09-06 19:46 ` Derrick Stolee
2024-09-06 20:21 ` [PATCH v2] scalar: add --no-tags option to 'scalar clone' Derrick Stolee via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwmjoyfwh.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.