From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>,
git@vger.kernel.org, Ramsay Jones <ramsay@ramsayjones.plus.com>,
Jeff King <peff@peff.net>
Subject: Re: [PATCH v2] sha256: add support for Nettle
Date: Sun, 10 Jul 2022 09:39:18 -0700 [thread overview]
Message-ID: <xmqqwnckrkg9.fsf@gitster.g> (raw)
In-Reply-To: <220710.86mtdh81ty.gmgdl@evledraar.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Sun, 10 Jul 2022 16:41:23 +0200")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> This just carries forward existing technical debt, but it's unfortunate
> that we don't catch OPENSSL_SHA256 overridding NETTLE_SHA256, and error
> if both are defined.
You are mistaken, unless I am ;-)
Allowing users to list whatever is available, instead of requiring
all users to choose only one, is a deliberate feature in the
arrangement, so it is not unfortunate and it would be breaking
end-user expectation if we gave an error when more than one is
given (and it would be easier to write and maintain autoconf rules
for the feature---we do not want to have two places that makes
decisions on precedence).
next prev parent reply other threads:[~2022-07-10 16:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 23:05 [PATCH] sha256: add support for Nettle brian m. carlson
2022-07-06 1:00 ` Ramsay Jones
2022-07-06 1:08 ` brian m. carlson
2022-07-06 8:23 ` Jeff King
2022-07-06 8:45 ` Ævar Arnfjörð Bjarmason
2022-07-06 9:23 ` Jeff King
2022-07-06 10:39 ` brian m. carlson
2022-07-06 17:49 ` Junio C Hamano
2022-07-06 23:05 ` Junio C Hamano
2022-07-07 6:43 ` Junio C Hamano
2022-07-07 16:18 ` Junio C Hamano
2022-07-10 13:29 ` [PATCH v2] " brian m. carlson
2022-07-10 14:41 ` Ævar Arnfjörð Bjarmason
2022-07-10 16:39 ` Junio C Hamano [this message]
2022-07-10 20:12 ` brian m. carlson
2022-07-10 20:37 ` Junio C Hamano
2022-08-31 5:34 ` Reza Mahdi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwnckrkg9.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=ramsay@ramsayjones.plus.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.