From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Cc: Jeff Hostetler <jeffhost@microsoft.com>
Subject: A couple more duplicate declarations
Date: Mon, 10 Jan 2022 11:52:01 -0800 [thread overview]
Message-ID: <xmqqwnj7xtb2.fsf_-_@gitster.g> (raw)
In-Reply-To: <xmqqfspvz8us.fsf@gitster.g> (Junio C. Hamano's message of "Mon, 10 Jan 2022 11:30:51 -0800")
Junio C Hamano <gitster@pobox.com> writes:
>> Thanks for cleaning up the duplicate, looks good to me!
>
> Thanks, both.
This is not urgent at all, given that we are about to enter the
pre-release stabilization period and patches that might result from
this message would become lower priority, but there are a couple of
duplicate declarations, which I'll mention in order to help people
to come back to them later.
* trace2_cmd_exit_fl() was added to git-compat-util.h and to
trace2.h by ee4512ed (trace2: create new combined trace facility,
2019-02-22). Logically it belongs to the latter. Moving
inclusion of the latter from <cache.h> to <git-compat-util.h>
might be the lowest-cost fix, but there may be ramifications.
* xdl_emit_diff() is declared in xdiff/xdiffi.h and xdiff/xemit.h; I
wonder if there is a caller that only includes one but not the
other header. As they came from the same upstream-import commit,
I wouldn't worry too much about it.
prev parent reply other threads:[~2022-01-10 19:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 18:41 [PATCH] cache.h: drop duplicate `ensure_full_index()` declaration Martin Ågren
2022-01-10 18:57 ` Victoria Dye
2022-01-10 19:30 ` Junio C Hamano
2022-01-10 19:52 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwnj7xtb2.fsf_-_@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jeffhost@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.