From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>,
"Felipe Contreras" <felipe.contreras@gmail.com>,
git@vger.kernel.org, "ZheNing Hu" <adlternative@gmail.com>,
"Fabian Stelzer" <fabian.stelzer@campoint.net>
Subject: Re: [PATCH] test: fix for COLUMNS and bash 5
Date: Mon, 23 Aug 2021 13:24:13 -0700 [thread overview]
Message-ID: <xmqqwnobq58y.fsf@gitster.g> (raw)
In-Reply-To: <87sfz0fh8o.fsf@evledraar.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Mon, 23 Aug 2021 14:59:10 +0200")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> Now that we're post-release are you interested in a re-roll of
> https://lore.kernel.org/git/cover-v3-0.3-00000000000-20210804T230335Z-avarab@gmail.com/
> + removal of the bash-specific checkwinsize added here, or would you
Let's wait until we see a concrete breakage report that shows that
checkwinsize is insufficient. Even if such a second shell calls its
facility differently, as long as it works in a similar way and
another single liner like
test -n "$BASH_VERSION" && shopt -u checkwinsize 2>/dev/null
we can keep piling such a single-liner next to each other, as the
number of shells we need to cater to would be less than a handful
anyway.
Thanks.
next prev parent reply other threads:[~2021-08-23 20:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 19:48 [PATCH] test: fix for COLUMNS and bash 5 Felipe Contreras
2021-08-05 23:35 ` Ævar Arnfjörð Bjarmason
2021-08-06 16:15 ` Felipe Contreras
2021-08-06 14:49 ` SZEDER Gábor
2021-08-06 16:59 ` Junio C Hamano
2021-08-23 12:59 ` Ævar Arnfjörð Bjarmason
2021-08-23 20:24 ` Junio C Hamano [this message]
2021-08-06 16:44 ` [PATCH v2] " Felipe Contreras
2021-08-07 1:37 ` ZheNing Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwnobq58y.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=adlternative@gmail.com \
--cc=avarab@gmail.com \
--cc=fabian.stelzer@campoint.net \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.