From: Junio C Hamano <gitster@pobox.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Beat Bolli <dev+git@drbeat.li>,
git@vger.kernel.org,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Jeff King <peff@peff.net>
Subject: Re: [PATCH] t3900: add some more quotes
Date: Wed, 10 Jan 2018 11:43:52 -0800 [thread overview]
Message-ID: <xmqqwp0p1ouf.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <6b32292b-0f71-7cf8-2069-41766d440b58@kdbg.org> (Johannes Sixt's message of "Wed, 10 Jan 2018 20:02:09 +0100")
Johannes Sixt <j6t@kdbg.org> writes:
>> test_expect_success 'UTF-8 invalid characters refused' '
>> - test_when_finished "rm -f \"$HOME/stderr $HOME/invalid\"" &&
>> + test_when_finished "rm -f \"$HOME/stderr\" \"$HOME/invalid\"" &&
>
> Should that not better be
>
> test_when_finished "rm -f \"\$HOME/stderr\" \"\$HOME/invalid\""
>
> i.e., delay the expansion of $HOME to protect against double-quotes in
> the path?
Yes ;-)
next prev parent reply other threads:[~2018-01-10 19:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 9:58 [PATCH] t3900: add some more quotes Beat Bolli
2018-01-10 10:33 ` Jeff King
2018-01-10 17:21 ` Johannes Schindelin
2018-01-10 17:44 ` Eric Sunshine
2018-01-10 22:38 ` [PATCH v2] " Beat Bolli
2018-01-10 23:09 ` Johannes Schindelin
2018-01-10 23:09 ` Junio C Hamano
2018-01-10 19:02 ` [PATCH] " Johannes Sixt
2018-01-10 19:43 ` Junio C Hamano [this message]
2018-01-10 19:53 ` Jeff King
2018-01-10 21:31 ` Junio C Hamano
2018-01-11 9:38 ` Jeff King
2018-01-11 11:39 ` read test snippet from stdin [was: [PATCH] t3900: add some more quotes] SZEDER Gábor
2018-01-11 12:11 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwp0p1ouf.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=dev+git@drbeat.li \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=johannes.schindelin@gmx.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.