From: Junio C Hamano <gitster@pobox.com>
To: tboegi@web.de
Cc: git@vger.kernel.org, asottile@umich.edu
Subject: [PATCH/FIXUP 3/2] apply: remove unused member apply_state.flags
Date: Wed, 16 Aug 2017 11:28:56 -0700 [thread overview]
Message-ID: <xmqqwp63l63b.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: 20170813085106.1731-1-tboegi@web.de
The previous step added the "flags" member to apply_state, but it is
never used. Remove it and move the bit assignment macro to apply.c
as that is just a private implementation detail.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
apply.c | 2 ++
apply.h | 4 ----
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/apply.c b/apply.c
index 63455cd65f..7663e63df7 100644
--- a/apply.c
+++ b/apply.c
@@ -2282,6 +2282,8 @@ static void show_stats(struct apply_state *state, struct patch *patch)
add, pluses, del, minuses);
}
+#define APPLY_FLAGS_CR_AT_EOL (1<<0)
+
static int read_old_data(struct stat *st, const char *path, struct strbuf *buf, int flags)
{
enum safe_crlf safe_crlf = flags & APPLY_FLAGS_CR_AT_EOL ?
diff --git a/apply.h b/apply.h
index 192140280f..b3d6783d55 100644
--- a/apply.h
+++ b/apply.h
@@ -33,13 +33,9 @@ enum apply_verbosity {
#define APPLY_SYMLINK_GOES_AWAY 01
#define APPLY_SYMLINK_IN_RESULT 02
-
-#define APPLY_FLAGS_CR_AT_EOL (1<<0)
-
struct apply_state {
const char *prefix;
int prefix_length;
- int flags;
/* These are lock_file related */
struct lock_file *lock_file;
--
2.14.1-331-g7631d96230
next prev parent reply other threads:[~2017-08-16 18:29 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 18:24 core.autocrlf=true causes `git apply` to fail on patch generated with `git diff-index HEAD --patch` Anthony Sottile
2017-08-01 20:47 ` Torsten Bögershausen
2017-08-01 20:58 ` Anthony Sottile
2017-08-02 15:44 ` Torsten Bögershausen
2017-08-02 20:42 ` [PATCH v1 1/1] correct apply for files commited with CRLF tboegi
2017-08-02 21:13 ` Junio C Hamano
2017-08-04 17:31 ` Torsten Bögershausen
2017-08-04 17:57 ` Junio C Hamano
2017-08-04 19:26 ` Junio C Hamano
2017-08-02 20:58 ` core.autocrlf=true causes `git apply` to fail on patch generated with `git diff-index HEAD --patch` Junio C Hamano
2017-08-12 5:45 ` Torsten Bögershausen
2017-08-12 5:53 ` Torsten Bögershausen
2017-08-12 14:56 ` [PATCH/RFC] convert: Add SAFE_CRLF_KEEP_CRLF tboegi
2017-08-12 14:56 ` [PATCH/RFC] File commited with CRLF should roundtrip diff and apply tboegi
2017-08-14 17:37 ` Junio C Hamano
2017-08-17 6:06 ` [PATCH v2 1/2] convert: Add SAFE_CRLF_KEEP_CRLF tboegi
2017-08-17 6:06 ` [PATCH v2 2/2] File commited with CRLF should roundtrip diff and apply tboegi
2017-08-17 6:37 ` Junio C Hamano
2017-08-17 21:43 ` [PATCH v3 1/2] convert: Add SAFE_CRLF_KEEP_CRLF tboegi
2017-08-17 21:43 ` [PATCH v3 2/2] File commited with CRLF should roundtrip diff and apply tboegi
2017-08-17 22:29 ` Junio C Hamano
2017-08-17 22:35 ` Junio C Hamano
2017-08-19 11:27 ` [PATCH v4 1/2] convert: Add SAFE_CRLF_KEEP_CRLF tboegi
2017-08-19 11:28 ` [PATCH v4 2/2] File commited with CRLF should roundtrip diff and apply tboegi
2017-08-13 8:51 ` [PATCH/RFC 1/2] convert: Add SAFE_CRLF_KEEP_CRLF tboegi
2017-08-13 8:51 ` [PATCH/RFC 2/2] File commited with CRLF should roundtrip diff and apply tboegi
2017-08-16 18:28 ` Junio C Hamano
2017-08-16 18:28 ` Junio C Hamano [this message]
2017-08-16 18:29 ` [PATCH/FIXUP 4/2] apply: only pay attention to CRLF in the preimage Junio C Hamano
2017-08-16 18:30 ` [PATCH/FIXUP 5/2] apply: localize the CRLF business to read_old_data() Junio C Hamano
2017-08-16 18:34 ` [PATCH/FIXUP 6/2] apply: clarify read_old_data() is about no-index case Junio C Hamano
2017-08-17 6:24 ` Torsten Bögershausen
2017-08-17 7:06 ` Junio C Hamano
2017-08-17 7:12 ` Junio C Hamano
2017-08-17 8:24 ` Torsten Bögershausen
2017-08-17 17:07 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwp63l63b.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=asottile@umich.edu \
--cc=git@vger.kernel.org \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.