From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <sbeller@google.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: What's cooking in git.git (Jun 2017, #06; Thu, 22)
Date: Fri, 23 Jun 2017 18:01:55 -0700 [thread overview]
Message-ID: <xmqqwp829p18.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <xmqq60fmb4q8.fsf@gitster.mtv.corp.google.com> (Junio C. Hamano's message of "Fri, 23 Jun 2017 17:37:35 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> But for the purpose of this "moved line coloring",
> excluding multiple copy destinations of the same thing may be a
> simpler and more robust solution. It will not catch "somebody
> stupidly removed one function and made two private copies", though.
Let me take this one back. Treating multiple copy destinations and
multiple copy sources differently is a bad idea. It is easy for a
user to give "-R" option to "diff" to turn such a stupid patch into
"somebody brilliantly consolidated two copies of the same thing into
a single function", and we want to keep "diff" and "diff -R" output
symmetric.
next prev parent reply other threads:[~2017-06-24 1:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-22 22:35 What's cooking in git.git (Jun 2017, #06; Thu, 22) Junio C Hamano
2017-06-22 22:58 ` Ævar Arnfjörð Bjarmason
2017-06-23 5:28 ` Junio C Hamano
2017-06-24 0:27 ` Junio C Hamano
2017-06-23 9:43 ` Lars Schneider
2017-06-23 21:59 ` Ævar Arnfjörð Bjarmason
2017-06-23 23:39 ` Stefan Beller
2017-06-24 0:37 ` Junio C Hamano
2017-06-24 1:01 ` Junio C Hamano [this message]
2017-06-27 2:58 ` Stefan Beller
2017-06-24 0:16 ` Stefan Beller
2017-06-24 0:33 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwp829p18.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.