From: Junio C Hamano <gitster@pobox.com>
To: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
Cc: git@vger.kernel.org, avarab@gmail.com
Subject: Re: [PATCH] status tests: fix a minor indenting issue
Date: Wed, 21 Jun 2017 09:34:12 -0700 [thread overview]
Message-ID: <xmqqwp85qozf.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1498048305.1746.6.camel@gmail.com> (Kaartic Sivaraam's message of "Wed, 21 Jun 2017 18:01:45 +0530")
Kaartic Sivaraam <kaarticsivaraam91196@gmail.com> writes:
> Change the indentation from "\t " to "\t". This indenting issue was
> introduced when the test was added in commit
> 1d2f393ac9 ("status/commit: show staged submodules regardless of
> ignore config", 2014-04-05).
>
> Helped-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> Signed-off-by: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
> t/t7508-status.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t7508-status.sh b/t/t7508-status.sh
> index 5edcc6edf..35ea0b707 100755
> --- a/t/t7508-status.sh
> +++ b/t/t7508-status.sh
> @@ -1494,7 +1494,7 @@ EOF
> test_expect_success 'git commit -m will commit a staged but ignored
> submodule' '
> git commit -uno -m message &&
> git status -s --ignore-submodules=dirty >output &&
> - test_i18ngrep ! "^M. sm" output &&
> + test_i18ngrep ! "^M. sm" output &&
> git config --remove-section submodule.subname &&
> git config -f .gitmodules --remove-section submodule.subname
> '
> --
> 2.11.0
Your patch is heavily whitespace damaged, line-wrapped and
full of <A0> (nbsp??) bytes as can be seen by downloading from
http://public-inbox.org/git/%3C1498048305.1746.6.camel@gmail.com%3E/raw
I'll hand-tweak to make it apply, so no need to resend but please
make sure you can send your patches cleanly before sending a more
substantial patch.
Thanks.
next prev parent reply other threads:[~2017-06-21 16:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 12:31 [PATCH] status tests: fix a minor indenting issue Kaartic Sivaraam
2017-06-21 16:34 ` Junio C Hamano [this message]
2017-06-21 18:18 ` Kaartic Sivaraam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwp85qozf.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=kaarticsivaraam91196@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.