From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <git-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: AS31976 209.132.180.0/23
X-Spam-Status: No, score=-5.6 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,
	RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by dcvr.yhbt.net (Postfix) with ESMTP id 40EF82042F
	for <e@80x24.org>; Wed, 16 Nov 2016 19:03:15 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752906AbcKPTDN (ORCPT <rfc822;e@80x24.org>);
        Wed, 16 Nov 2016 14:03:13 -0500
Received: from pb-smtp1.pobox.com ([64.147.108.70]:59929 "EHLO
        sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
        with ESMTP id S1752275AbcKPTDM (ORCPT <rfc822;git@vger.kernel.org>);
        Wed, 16 Nov 2016 14:03:12 -0500
Received: from sasl.smtp.pobox.com (unknown [127.0.0.1])
        by pb-smtp1.pobox.com (Postfix) with ESMTP id 1D5F04ED70;
        Wed, 16 Nov 2016 14:03:11 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc
        :subject:references:date:in-reply-to:message-id:mime-version
        :content-type; s=sasl; bh=RjHz9KM3tr3e1Sfv6z3qTc96kng=; b=vp8yV7
        4jf2b+sLU81uYrZYKDl9R6EIMtpIK4KTpJzzpuN4H4O3tnlDQc0trYEPLqmm4yUZ
        FycDKAif67Jw7RqjLSNgwlehhntCvVcSQtysMFIs8OE9+6YhqUEuhnAz2uujJ9+I
        Js6jndFtjQlXCtrpemHIBx6H1o6mzbAR2HzLI=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc
        :subject:references:date:in-reply-to:message-id:mime-version
        :content-type; q=dns; s=sasl; b=ZURyU9xplevwEVIpN2CHps7WQs/gQuXm
        NI1PtbBULuHIWRBGIGyqsC0yOrwitc7WhQEOP6TWAQL/EmmMUgXk2QcPMSjg2852
        yamLHyI8iiMexuT8C1gi9hRL28JLknQIDFNn672zf25bp3VNVb/2w/7tdvRBIpYQ
        j08Mzvf2Uao=
Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1])
        by pb-smtp1.pobox.com (Postfix) with ESMTP id 14D444ED6F;
        Wed, 16 Nov 2016 14:03:11 -0500 (EST)
Received: from pobox.com (unknown [104.132.0.95])
        (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits))
        (No client certificate requested)
        by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 887BB4ED6E;
        Wed, 16 Nov 2016 14:03:10 -0500 (EST)
From:   Junio C Hamano <gitster@pobox.com>
To:     David Turner <David.Turner@twosigma.com>
Cc:     'Stefan Beller' <sbeller@google.com>,
        "git\@vger.kernel.org" <git@vger.kernel.org>,
        "bmwill\@google.com" <bmwill@google.com>,
        "jrnieder\@gmail.com" <jrnieder@gmail.com>,
        "mogulguy10\@gmail.com" <mogulguy10@gmail.com>
Subject: Re: [PATCH 02/16] submodule: modernize ok_to_remove_submodule to use argv_array
References: <20161115230651.23953-1-sbeller@google.com>
        <20161115230651.23953-3-sbeller@google.com>
        <e19fbbca91d5446e8fe308e847f53ae3@exmbdft7.ad.twosigma.com>
Date:   Wed, 16 Nov 2016 11:03:09 -0800
In-Reply-To: <e19fbbca91d5446e8fe308e847f53ae3@exmbdft7.ad.twosigma.com>
        (David Turner's message of "Tue, 15 Nov 2016 23:11:15 +0000")
Message-ID: <xmqqwpg3p7rm.fsf@gitster.mtv.corp.google.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Pobox-Relay-ID: 512791DC-AC2F-11E6-9C2A-987C12518317-77302942!pb-smtp1.pobox.com
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org

David Turner <David.Turner@twosigma.com> writes:

>> -		"-u",
> ...
>> +	argv_array_pushl(&cp.args, "status", "--porcelain", "-uall",
>
> This also changes -u to -uall, which is not mentioned in the
> commit message.  That should probably be called out.

Or not making that change at all.  Isn't "-u" the same as "-uall"?