All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <sbeller@google.com>
Cc: "git\@vger.kernel.org" <git@vger.kernel.org>,
	mst@redhat.com, Jens Lehmann <Jens.Lehmann@web.de>
Subject: Re: [PATCH 2/6] t7408: merge short tests, factor out testing method
Date: Fri, 05 Aug 2016 16:09:15 -0700	[thread overview]
Message-ID: <xmqqwpjuu82s.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAGZ79kZChXebtSJeTPGoZgnoKySDrWnD11NX7fyze+rOU=Jwvg@mail.gmail.com> (Stefan Beller's message of "Fri, 5 Aug 2016 15:45:13 -0700")

Stefan Beller <sbeller@google.com> writes:

>>> -test_expect_success 'that reference gets used with add' '
>>> -     (
>>> -             cd super/sub &&
>>> -             echo "0 objects, 0 kilobytes" > expected &&
>>> -             git count-objects > current &&
>>> -             diff expected current
>
> This is where the "diff" and "current" above came from.

I KNOW that, but I thought this effort is a continuation of the
modernise-and-make-it-maintainable effort started at 1/6.

> To stop that from happening again I want to have a clean slate,
> i.e. all clones are deleted shortly after using, so it is obvious what
> to use for testing.

OK.  So A, B and super (and super/sub) are the ones that survive
throughout the test, and individual test (including the "let's try
cloning the super into super-clone" at the end of existing tests)
would follow create-use-remove pattern?  Perhaps that can be left
as a comment before the last existing test, e.g. "A, B and super are
permanent, and from here on, if you create a clone of them for
testing, remove your clone once you are done", to inform the test
writers of this convention.

Thanks.

  reply	other threads:[~2016-08-06 20:05 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-04 19:51 [PATCH 0/6] git clone: Marry --recursive and --reference Stefan Beller
2016-08-04 19:51 ` [PATCH 1/6] t7408: modernize style Stefan Beller
2016-08-05 20:30   ` Junio C Hamano
2016-08-04 19:51 ` [PATCH 2/6] t7408: merge short tests, factor out testing method Stefan Beller
2016-08-05 20:45   ` Junio C Hamano
2016-08-05 22:45     ` Stefan Beller
2016-08-05 23:09       ` Junio C Hamano [this message]
2016-08-04 19:51 ` [PATCH 3/6] submodule--helper module-clone: allow multiple references Stefan Beller
2016-08-05 20:54   ` Junio C Hamano
2016-08-04 19:51 ` [PATCH 4/6] submodule--helper update-clone: " Stefan Beller
2016-08-05 19:08   ` Stefan Beller
2016-08-05 21:06     ` Junio C Hamano
2016-08-05 21:19       ` Stefan Beller
2016-08-05 21:31         ` Junio C Hamano
2016-08-05 21:33           ` Stefan Beller
2016-08-04 19:51 ` [PATCH 5/6] submodule update: add super-reference flag Stefan Beller
2016-08-05 21:16   ` Junio C Hamano
2016-08-06  0:22     ` Stefan Beller
2016-08-04 19:51 ` [PATCH 6/6] clone: reference flag is used for submodules as well Stefan Beller
2016-08-05 21:36   ` Junio C Hamano
2016-08-05 19:47 ` [PATCH 0/6] git clone: Marry --recursive and --reference Junio C Hamano
2016-08-05 21:23   ` Stefan Beller
2016-08-05 21:47     ` Junio C Hamano
2016-08-05 23:26 ` Rename detection within in files WAS: [PATCH 2/6] t7408: merge short tests, factor out testing method Stefan Beller
2016-08-07  9:24   ` René Scharfe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqwpjuu82s.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=Jens.Lehmann@web.de \
    --cc=git@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=sbeller@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.