From: Junio C Hamano <gitster@pobox.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH v2 3/3] http: expand http.cookieFile as a path
Date: Wed, 04 May 2016 16:03:13 -0700 [thread overview]
Message-ID: <xmqqwpn9ctou.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160504193531.GA62336@google.com> (Brian Norris's message of "Wed, 4 May 2016 12:35:31 -0700")
Brian Norris <computersforpeace@gmail.com> writes:
> On Wed, May 04, 2016 at 03:30:51PM -0400, Jeff King wrote:
>> On Wed, May 04, 2016 at 11:42:15AM -0700, Brian Norris wrote:
>>
>> > diff --git a/Documentation/config.txt b/Documentation/config.txt
>> > index e655b9729a7d..4c3cd7621ad0 100644
>> > --- a/Documentation/config.txt
>> > +++ b/Documentation/config.txt
>> > @@ -1664,7 +1664,8 @@ http.emptyAuth::
>> > authentication.
>> >
>> > http.cookieFile::
>> > - File containing previously stored cookie lines which should be used
>> > + The pathname of a file containing previously stored cookie lines,
>> > + which should be used
>> > in the Git http session, if they match the server. The file format
>> > of the file to read cookies from should be plain HTTP headers or
>> > the Netscape/Mozilla cookie file format (see linkgit:curl[1]).
>>
>> I think we usually re-wrap paragraphs when adding to the documentation,
>> but I do not have a strong opinion (and certainly understand the reasons
>> for not doing so).
>
> I chose the wrapping mostly based on the diff suggestions y'all kindly
> provided :)
>
> I can rewrap and resend if necessary.
>
>> The whole series looks fine to me. Thanks.
If the rewrite were a lot more extensive, then it no longer would make
sense to refrain from rewrapping (which reduces the number of lines
eyes have to scan), but doing this without rewrapping I think
strikes a good balance.
prev parent reply other threads:[~2016-05-04 23:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 18:42 [PATCH v2 1/3] config: describe 'pathname' value type Brian Norris
2016-05-04 18:42 ` [PATCH v2 2/3] Documentation: config: improve word ordering for http.cookieFile Brian Norris
2016-05-04 18:42 ` [PATCH v2 3/3] http: expand http.cookieFile as a path Brian Norris
2016-05-04 19:30 ` Jeff King
2016-05-04 19:35 ` Brian Norris
2016-05-04 23:03 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwpn9ctou.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=computersforpeace@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.