From: Junio C Hamano <gitster@pobox.com>
To: "Steinar H. Gunderson" <sgunderson@bigfoot.com>
Cc: git@vger.kernel.org
Subject: Re: Please document git-http-backend/Apache timeout interactions
Date: Sun, 21 Feb 2016 15:29:56 -0800 [thread overview]
Message-ID: <xmqqwppx8wwb.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160221221744.GA38068@sesse.net> (Steinar H. Gunderson's message of "Sun, 21 Feb 2016 23:17:44 +0100")
"Steinar H. Gunderson" <sgunderson@bigfoot.com> writes:
> I am running git-http-backend behind Apache as suggested in
> git-http-backend(1). However, what it fails to mention is that
> git-fetch-pack seemingly can be very slow in sending its request.
> Consequently, mod_reqtimeout (on by default, as I understand it)
> kicks in as an anti-DoS measure, and the user sees a 408 (timeout)
> error.
>
> Seemingly the simplest fix is to turn off mod_reqtimeout in the vhost
> serving git (potentially with some <IfModule> around it):
>
> RequestReadTimeout header=0 body=0
>
> Would you consider adding this to the documentation?
This feels 70% like "how to configure your Apache server when you
run site that is contacted by a client that is slow to talk?", that
is not necessarily specific to Git.
Also while it may make sense to tweak the timeout on the server
side, recommending to disable it altogether, instead of adjusting to
the typical requirement for a sane client, feels just wrong.
Also, are all requests from one client slow to start, or are only
some phases in the protocol exchange slow but not others? If the
server side can tell which ones could be normally slow, selectively
loosening timeouts only for them might be more palatable, but I am
sensing that you are not suggesting such an approach.
For these reasons, I am on the fence.
next prev parent reply other threads:[~2016-02-21 23:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-21 22:17 Please document git-http-backend/Apache timeout interactions Steinar H. Gunderson
2016-02-21 23:29 ` Junio C Hamano [this message]
2016-02-21 23:34 ` Steinar H. Gunderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwppx8wwb.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=sgunderson@bigfoot.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.