From: Junio C Hamano <gitster@pobox.com>
To: Elia Pinto <gitter.spiros@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 03/22] argv-array.h: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf'
Date: Thu, 11 Feb 2016 13:49:40 -0800 [thread overview]
Message-ID: <xmqqwpqavrwr.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <xmqqd1s3vuhy.fsf@gitster.mtv.corp.google.com> (Junio C. Hamano's message of "Thu, 11 Feb 2016 12:53:45 -0800")
Junio C Hamano <gitster@pobox.com> writes:
> OK, this may answer my previous question.
>
> It might be pleasing to the eyes when these two macros appearing
> together in all CAPS, making them look similar and consistent,
> perhaps with two more tweaks:
>
> - Imitate LAST_ARG_MUST_BE_NULL and spell it FORMAT_PRINTF;
>
> - Consistently have SP after comma, i.e. FORMAT_PRINTF(2, 3),
> or to make it obvious that this thing is a special magic, drop SP
> (i.e. this patch would stay the same but some other patches left
> a space after comma, which made them look more inconsistent).
>
> Thanks. I am not 100% sold on this yet, though.
Regarding the second one, I misread the patch series. You
consistently drop space and make the result FORMATPRINTF(X,Y).
I was fooled by the inconsistent original text, some of them using
__attribute__((format (printf, X, Y))) while others saying
__attribute__((format(printf,X,Y)) and some other variants.
next prev parent reply other threads:[~2016-02-11 21:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 12:38 [PATCH 00/22] add the FORMATPRINTF macro to declare the gcc function Elia Pinto
2016-02-11 12:38 ` [PATCH 01/22] git-compat-util.h: add the FORMATPRINTF macro Elia Pinto
2016-02-11 12:38 ` [PATCH 02/22] advice.h: use the FORMATPRINTF macro to declare the gcc function attribute 'format printf' Elia Pinto
2016-02-11 12:38 ` [PATCH 03/22] argv-array.h: " Elia Pinto
2016-02-11 20:53 ` Junio C Hamano
2016-02-11 21:49 ` Junio C Hamano [this message]
2016-02-11 12:38 ` [PATCH 04/22] builtin/index-pack.c: " Elia Pinto
2016-02-11 12:38 ` [PATCH 05/22] builtin/receive-pack.c: " Elia Pinto
2016-02-11 12:38 ` [PATCH 06/22] builtin/update-index.c: " Elia Pinto
2016-02-11 12:38 ` [PATCH 07/22] builtin/upload-archive.c: " Elia Pinto
2016-02-11 12:38 ` [PATCH 08/22] cache.h: " Elia Pinto
2016-02-11 12:38 ` [PATCH 09/22] color.h: " Elia Pinto
2016-02-11 12:38 ` [PATCH 10/22] config.c: " Elia Pinto
2016-02-11 12:38 ` [PATCH 11/22] daemon.c: " Elia Pinto
2016-02-11 12:38 ` [PATCH 12/22] fsck.c: " Elia Pinto
2016-02-11 12:38 ` [PATCH 13/22] http-backend.c: " Elia Pinto
2016-02-11 12:38 ` [PATCH 14/22] imap-send.c: " Elia Pinto
2016-02-11 12:38 ` [PATCH 15/22] merge-recursive.c: " Elia Pinto
2016-02-11 12:38 ` [PATCH 16/22] pkt-line.h: " Elia Pinto
2016-02-11 12:38 ` [PATCH 17/22] remote.c: " Elia Pinto
2016-02-11 12:38 ` [PATCH 18/22] strbuf.h: " Elia Pinto
2016-02-11 12:38 ` [PATCH 19/22] trace.h: " Elia Pinto
2016-02-11 12:38 ` [PATCH 20/22] transport-helper.c: " Elia Pinto
2016-02-11 12:38 ` [PATCH 21/22] utf8.h: " Elia Pinto
2016-02-11 12:38 ` [PATCH 22/22] wt-status.h: " Elia Pinto
2016-02-11 17:59 ` [PATCH 00/22] add the FORMATPRINTF macro to declare the gcc function Junio C Hamano
2016-02-11 22:33 ` Jeff King
2016-02-18 21:59 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwpqavrwr.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitter.spiros@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.