From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Jonathan Lebon <jonathan.lebon@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 1/4] diff-highlight: add `less -r` to cmd in README
Date: Tue, 03 Nov 2015 13:51:54 -0800 [thread overview]
Message-ID: <xmqqwptybvk5.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20151103211435.GA22484@sigill.intra.peff.net> (Jeff King's message of "Tue, 3 Nov 2015 16:14:36 -0500")
Jeff King <peff@peff.net> writes:
> I agree with Junio that "-R" is a more sensible default, but I don't
> think that should be necessary. We already set LESS when running the
> pager (and if you are overriding it, you are already in trouble, because
> git itself will generate ANSI codes by default).
I do not quite understand this part. Inside git itself when we
spawn the pager we export LESS with a sensible default, exactly to
help users who do not have LESS set and exported. This one however
is not spawned by git but the end-user piping output of diff-hilite.
I agree that if the user has LESS exported without -R that would not
be pretty while viewing coloured output.
next prev parent reply other threads:[~2015-11-03 21:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 2:05 [PATCH 0/4] diff-highlight: make a few improvements Jonathan Lebon
2015-11-03 2:05 ` [PATCH 1/4] diff-highlight: add `less -r` to cmd in README Jonathan Lebon
2015-11-03 2:41 ` Junio C Hamano
2015-11-03 3:12 ` Jonathan Lebon
2015-11-03 21:14 ` Jeff King
2015-11-03 21:51 ` Junio C Hamano [this message]
2015-11-03 21:55 ` Jeff King
2015-11-03 2:05 ` [PATCH 2/4] diff-highlight: factor out prefix/suffix functions Jonathan Lebon
2015-11-03 21:17 ` Jeff King
2015-11-03 2:05 ` [PATCH 3/4] diff-highlight: match up lines before highlighting Jonathan Lebon
2015-11-03 21:44 ` Jeff King
2015-11-03 22:03 ` Jeff King
2015-11-17 5:18 ` Jonathan Lebon
2015-11-17 22:50 ` Jeff King
2015-11-03 2:05 ` [PATCH 4/4] diff-highlight: add maxhunksize config option Jonathan Lebon
2015-11-03 21:46 ` Jeff King
2015-11-03 22:07 ` [PATCH 0/4] diff-highlight: make a few improvements Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwptybvk5.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jonathan.lebon@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.