All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Vitor Antunes <vitor.hda@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/2] git-p4: Small updates to test cases
Date: Thu, 26 Mar 2015 18:26:30 -0700	[thread overview]
Message-ID: <xmqqwq23w7qx.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1427418269-3263-1-git-send-email-vitor.hda@gmail.com> (Vitor Antunes's message of "Fri, 27 Mar 2015 01:04:27 +0000")

Vitor Antunes <vitor.hda@gmail.com> writes:

> This patch set includes two small fixes to the rename test case. The fix to
> support dash should be trivial, but in the fix to the copy detection test case
> it isn't obvious to me what changed in diff-tree to result in a different file
> being detected as the origin of a copy.

Thanks.

As to 1/2 the lack of esac is clearly a bug---any self respecting
POSIX shell should have executed it without complaining.  But
changing from ':' to true should not be necessary---after all, the
colon is a more traditional way to spell true to Bourne shells, and
we use it in many places already.  Can you try reverting all the
"colon to true" bits, keeping only the "add missing esac" part, and
run your tests again?

  parent reply	other threads:[~2015-03-27  1:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-27  1:04 [PATCH 0/2] git-p4: Small updates to test cases Vitor Antunes
2015-03-27  1:04 ` [PATCH 1/2] git-p4: Make rename test case runnable under dash Vitor Antunes
2015-03-27  1:04 ` [PATCH 2/2] git-p4: Fix copy detection test Vitor Antunes
2015-03-27 22:23   ` Junio C Hamano
2015-03-27 23:59     ` Vitor Antunes
2015-03-28  0:36       ` Vitor Antunes
2015-03-28 16:12         ` Junio C Hamano
2015-03-27  1:26 ` Junio C Hamano [this message]
2015-03-27  1:45   ` [PATCH 0/2] git-p4: Small updates to test cases Junio C Hamano
2015-03-27  1:54   ` Vitor Antunes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqwq23w7qx.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=vitor.hda@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.