From: Junio C Hamano <gitster@pobox.com>
To: Pete Wyckoff <pw@padd.com>
Cc: Christoph Bonitz <ml.christophbonitz@gmail.com>, git@vger.kernel.org
Subject: Re: Test failure in t9814-git-p4-rename.sh - my environment or bad test?
Date: Mon, 07 Jul 2014 14:14:58 -0700 [thread overview]
Message-ID: <xmqqwqboc1m5.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140707011017.GA3802@padd.com> (Pete Wyckoff's message of "Sun, 6 Jul 2014 21:10:17 -0400")
Pete Wyckoff <pw@padd.com> writes:
> I'm not sure how to robustify this. At least doing the multiple
> comparisons should make the tests work again. The goal of this
> series of tests is to make sure that copy detection is working,
> not to verify that the correct copy choice was made. That should
> be in other (non-p4) tests.
"Choosing any of these as the copy source is fine" is a sensible way
to fix the problem with this test. Would it be a better solution to
avoid having multiple/ambiguous copy source candidates in the first
place, by the way?
> Do send patches based on Junio's master. I can ack, and they'll
> show up in a future git release.
>
> Thanks!
>
> -- Pete
next prev parent reply other threads:[~2014-07-07 21:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-06 14:32 Test failure in t9814-git-p4-rename.sh - my environment or bad test? Christoph Bonitz
2014-07-07 1:10 ` Pete Wyckoff
2014-07-07 21:14 ` Junio C Hamano [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-07-23 21:26 Christoph Bonitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwqboc1m5.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ml.christophbonitz@gmail.com \
--cc=pw@padd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.