All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: "Christian Couder" <chriscool@tuxfamily.org>,
	"git@vger.kernel.org" <git@vger.kernel.org>,
	"Jeff King" <peff@peff.net>, "Jakub Narębski" <jnareb@gmail.com>
Subject: Re: [PATCH] contrib: add convert-grafts-to-replace-refs.sh
Date: Tue, 27 May 2014 15:00:10 -0700	[thread overview]
Message-ID: <xmqqwqd6evbp.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAPig+cR4G916TwqGDRMr9fAH=SZkUB8kqGy3Hy5YBHZLgUw8ig@mail.gmail.com> (Eric Sunshine's message of "Tue, 27 May 2014 17:19:47 -0400")

Eric Sunshine <sunshine@sunshineco.com> writes:

>> +echo "Success! All the grafts in '$GRAFTS_FILE' have been converted to replace refs!"
>> +echo "You should now move away or delete the grafts file: '$GRAFTS_FILE'"
>
> Rather than merely giving advice, would it make sees for the script
> rename the file (adding .bak or some such) and report that it did so?

Yeah, I would say so.

      reply	other threads:[~2014-05-27 22:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20140527182719.14437.62235.chriscool@tuxfamily.org>
2014-05-27 21:19 ` [PATCH] contrib: add convert-grafts-to-replace-refs.sh Eric Sunshine
2014-05-27 22:00   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqwqd6evbp.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    --cc=peff@peff.net \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.