All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Max Horn <max@quendi.de>
Cc: "Torsten Bögershausen" <tboegi@web.de>,
	"git@vger.kernel.org" <git@vger.kernel.org>,
	"Antoine Pelisse" <apelisse@gmail.com>
Subject: Re: What's cooking in git.git (Mar 2014, #03; Fri, 14)
Date: Wed, 19 Mar 2014 11:53:06 -0700	[thread overview]
Message-ID: <xmqqwqfq2f71.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <0CF0981E-FFF8-4A38-B690-17826686BEA6@quendi.de> (Max Horn's message of "Wed, 19 Mar 2014 18:21:04 +0100")

Max Horn <max@quendi.de> writes:

> So, one more silly (bikeshedding) question: should I do this as one big
> patch adding multiple xfail tests - or one commit per test, with perhaps a
> brief description of the issue at hand? Or should a code comment next to
> the failing test explain things?

Judging from the next paragraph, one patch per issue sounds like a
good organization to help those who would want to fix these issues.

> Actually, some of those bugs might require a lengthy background
> explanation, so yet another variant would be to write an email here
> With an explanation, then add a gmane ref to the commit message...

Please first try to find a way that does not need any external
references---not everybody is always online.  A two-page description
in the log message for a new five-line test_expect_fail piece is
perfectly fine.

  reply	other threads:[~2014-03-19 18:53 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-14 22:09 What's cooking in git.git (Mar 2014, #03; Fri, 14) Junio C Hamano
2014-03-15  8:15 ` Torsten Bögershausen
2014-03-17 17:01   ` Junio C Hamano
2014-03-19 10:53     ` Max Horn
2014-03-19 12:32       ` Max Horn
2014-03-19 17:04       ` Junio C Hamano
2014-03-19 17:21         ` Max Horn
2014-03-19 18:53           ` Junio C Hamano [this message]
2014-03-15 12:34 ` Duy Nguyen
2014-03-17 18:05   ` Junio C Hamano
2014-03-16 18:30 ` Philip Oakley
2014-03-16 23:15   ` Ramkumar Ramachandra
2014-03-17 18:01     ` Junio C Hamano
2014-03-17 22:41     ` Philip Oakley
2014-03-17 17:21   ` Junio C Hamano
2014-03-18  0:16     ` Philip Oakley
2014-03-18  4:40   ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqwqfq2f71.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=apelisse@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=max@quendi.de \
    --cc=tboegi@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.