All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Harald Nordgren <haraldnordgren@gmail.com>
Cc: "Elia Pinto" <gitter.spiros@gmail.com>,
	git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH v2] status: reword message for a missing upstream branch
Date: Tue, 17 Nov 2026 15:29:11 -0800	[thread overview]
Message-ID: <xmqqy0ar9gvs.fsf@gitster.g> (raw)
In-Reply-To: <CAHwyqnXmOFTYLM6Am54SGE7Za9wiVS+0uJQhZfxeomS18COLvg@mail.gmail.com> (Harald Nordgren's message of "Tue, 17 Nov 2026 23:03:13 +0100")

Harald Nordgren <haraldnordgren@gmail.com> writes:

> v2 looks good to me.

This and another single liner "The idea makes sense to me!" you sent
to the RFC are both nice encouragements, but does not help assessing
the goodness of the patch because it is hard to tell for those
watching from the sidelines how deeply the "reviewer" actually read
the code, understood the issues, before coming up with the verdict.

Giving a positive review is much harder than pointing out issues in
a patch, but we should aim to become better at it.

Thanks.


      reply	other threads:[~2026-11-17 23:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-19 17:57 [PATCH] status: reword message for a missing upstream branch Elia Pinto
2026-10-19 18:04 ` Harald Nordgren
2026-10-19 21:42 ` Junio C Hamano
2026-10-20  7:29   ` Elia Pinto
2026-10-21  7:21 ` [PATCH v2] " Elia Pinto
2026-10-30  9:05   ` Elia Pinto
2026-11-17 21:27     ` Elia Pinto
2026-11-17 22:03       ` Harald Nordgren
2026-11-17 23:29         ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqy0ar9gvs.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitter.spiros@gmail.com \
    --cc=haraldnordgren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.