From: Junio C Hamano <gitster@pobox.com>
To: Orgad Shaneh <orgads@gmail.com>
Cc: "Orgad Shaneh via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Orgad Shaneh" <orgad.shaneh@audiocodes.com>
Subject: Re: [PATCH 2/2] fetch: clobber existing tags with --prune-tags
Date: Sun, 13 Sep 2026 15:57:01 -0700 [thread overview]
Message-ID: <xmqqy0d47oaq.fsf@gitster.g> (raw)
In-Reply-To: <CAGHpTBLvZGAaqkue47Ne9DHPSwxx4fPo5KusP5=sh3C2AxgAMA@mail.gmail.com> (Orgad Shaneh's message of "Sun, 13 Sep 2026 22:03:43 +0300")
Orgad Shaneh <orgads@gmail.com> writes:
> On Thu, Mar 26, 2026 at 9:57 AM Orgad Shaneh <orgads@gmail.com> wrote:
>>
>> On Sat, Mar 21, 2026 at 8:27 PM Junio C Hamano <gitster@pobox.com> wrote:
>> >
>> > None of the steps we see in the added test do not seem to check that
>> > --prune-tags does clobber existing tag that no longer exists on the
>> > other side. It only checks the "git fetch" command exits with
>> > status 0, but does not see if the tag actually went away after the
>> > operation is done.
>>
>> In these tests, the tag is being replaced rather than deleted. Existing
>> tests for the pruning mechanism itself are located in t/t5510-fetch.sh.
>>
>> Would you like me to add a check for the tag content itself to verify
>> the update? I suppose I should do the same for the existing test cases
>> in that block as well.
>
> Junio?
Sorry, but I do not have 6 month old discussions in my context
window, so no immediate comment. I'll respond only after I swap the
context back in but not today (yet).
Thanks.
next prev parent reply other threads:[~2026-09-13 22:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-15 20:23 [PATCH 0/2] fetch: clobber existing tags with --prune-tags Orgad Shaneh via GitGitGadget
2026-02-15 20:23 ` [PATCH 1/2] fetch: add a test for --force flag Orgad Shaneh via GitGitGadget
2026-02-15 20:23 ` [PATCH 2/2] fetch: clobber existing tags with --prune-tags Orgad Shaneh via GitGitGadget
2026-03-18 8:27 ` Orgad Shaneh
2026-03-21 18:26 ` Junio C Hamano
2026-03-26 7:57 ` Orgad Shaneh
2026-09-13 19:03 ` Orgad Shaneh
2026-09-13 22:57 ` Junio C Hamano [this message]
2026-10-06 17:44 ` Orgad Shaneh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy0d47oaq.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=orgad.shaneh@audiocodes.com \
--cc=orgads@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.