All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Michael Montalbo <mmontalbo@gmail.com>,
	 Patrick Steinhardt <ps@pks.im>,
	git@vger.kernel.org
Subject: Re: [PATCH 3/3] t5551: pack refs after creating many tags
Date: Sun, 28 Jun 2026 14:25:56 -0700	[thread overview]
Message-ID: <xmqqy0fy1hnf.fsf@gitster.g> (raw)
In-Reply-To: <20260628080710.GC107826@coredump.intra.peff.net> (Jeff King's message of "Sun, 28 Jun 2026 04:07:10 -0400")


Jeff King <peff@peff.net> writes:

> So let's follow that recommendation and pack the refs ourselves.
> Unfortunately, this does not seem to produce an improvement to the
> run-time of the test script! That's because after producing this state,
> we perform only a few fetches of it. And packing the refs costs at least
> as much as serving a ref advertisement (both have to iterate the refs,
> but packing additionally must write .lock files as we pack).

Testing a pathological set-up with too many loose refs may have
extra value, as long as we are also testing the recommended set-up,
so ideally we should have both ;-) but if we have to pick only one
and drop the other, we probably should be testing the packed case.

> I'm iffy on whether this one is worth it.

I am ambivalent, too, about this change for the purpose of the
"yeek, apache times out while enumerating refs" issue.  But see
above ;-)


  reply	other threads:[~2026-06-28 21:25 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-20 15:33 [RFH] Why do osx CI jobs so unreliable? Michael Montalbo
2026-06-21 21:34 ` Jeff King
2026-06-22  4:42   ` Patrick Steinhardt
2026-06-22  9:47     ` Patrick Steinhardt
2026-06-22  9:55       ` Patrick Steinhardt
2026-06-22 10:29         ` Patrick Steinhardt
2026-06-26  3:27           ` Michael Montalbo
2026-06-26  5:16             ` Jeff King
2026-06-26 10:50               ` Patrick Steinhardt
2026-06-26 13:45                 ` Junio C Hamano
2026-06-26 23:26                 ` Michael Montalbo
2026-06-28  7:57                   ` [PATCH 0/3] fixing expensive http test timeouts Jeff King
2026-06-28  8:00                     ` [PATCH 1/3] t/lib-httpd: bump apache timeout Jeff King
2026-07-02  3:24                       ` Michael Montalbo
2026-06-28  8:03                     ` [PATCH 2/3] t5551: put many-tags case into its own repo Jeff King
2026-06-28 21:44                       ` Junio C Hamano
2026-06-29  0:34                         ` Jeff King
2026-06-29 14:42                           ` Junio C Hamano
2026-06-29 20:36                             ` Jeff King
2026-06-28  8:07                     ` [PATCH 3/3] t5551: pack refs after creating many tags Jeff King
2026-06-28 21:25                       ` Junio C Hamano [this message]
2026-06-29  5:57                       ` Patrick Steinhardt
2026-06-29 20:35                         ` Jeff King
2026-06-30  9:05                           ` Patrick Steinhardt
2026-06-30 23:47                             ` Jeff King
2026-06-30 23:58                               ` weird quadratic reftable behavior, was: " Jeff King
2026-07-01  6:17                                 ` Patrick Steinhardt
2026-07-01  8:00                                   ` Jeff King
2026-07-01  9:04                                     ` Kristofer Karlsson
2026-07-01 10:07                                       ` Patrick Steinhardt
2026-07-03 12:09                                         ` Kristofer Karlsson
2026-07-06  6:46                                           ` Patrick Steinhardt
2026-07-06 11:37                                             ` Kristofer Karlsson
2026-06-29  7:33                     ` [PATCH 0/3] fixing expensive http test timeouts Patrick Steinhardt
2026-06-29 14:39                       ` Junio C Hamano
2026-06-29 16:09                         ` Patrick Steinhardt
2026-06-29 16:19                           ` Junio C Hamano
2026-06-30  9:05                             ` Patrick Steinhardt
2026-06-30 19:21                               ` Junio C Hamano
2026-07-01  6:56                                 ` Patrick Steinhardt
2026-06-26 23:43                 ` [RFH] Why do osx CI jobs so unreliable? Jeff King
2026-06-22  5:05   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqy0fy1hnf.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=mmontalbo@gmail.com \
    --cc=peff@peff.net \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.