From: Junio C Hamano <gitster@pobox.com>
To: "D. Ben Knoble" <ben.knoble+github@gmail.com>,
"Jean-Noël Avila" <jn.avila@free.fr>
Cc: git@vger.kernel.org, Christian Couder <chriscool@tuxfamily.org>,
Kristoffer Haugsbakk <code@khaugsbakk.name>,
Elijah Newren <newren@gmail.com>,
"brian m. carlson" <sandals@crustytoothpaste.net>,
Sergey Organov <sorganov@gmail.com>
Subject: Re: [PATCH] replay: drop rev-list formatting options from manual
Date: Tue, 20 Jan 2026 15:11:05 -0800 [thread overview]
Message-ID: <xmqqy0lrx4l2.fsf@gitster.g> (raw)
In-Reply-To: <xmqq3440x8da.fsf@gitster.g> (Junio C. Hamano's message of "Tue, 20 Jan 2026 13:49:21 -0800")
Junio C Hamano <gitster@pobox.com> writes:
> Junio C Hamano <gitster@pobox.com> writes:
>
>> "D. Ben Knoble" <ben.knoble+github@gmail.com> writes:
>>
>>> If I've understood all that correctly, then I have the Python version
>>> installed for building Git and it understood the syntax. Given that
>>> the Ruby version is newer, I think it should also work against the
>>> spec.
>>
>> We have CI jobs to catch the differences so hopefully we know soon
>> enough if one is so badly broken ;-)
>>
>> Thanks.
>
> We didn't have to wait for CI jobs. You can try
>
> make -C Documentation lint-docs
>
> which reveals that somebody is not expecting these multiple things
> there. I think Documentation/lint-gitlink.perl needs updating.
Perhaps something like this. Haven't thought things through to spot
negative ramifications, though.
The original comes from f81a574f (doc: test linkgit macros for
well-formedness, 2025-08-11); its author Cc'ed for better ideas.
----- >8 -----
Subject: [PATCH] lint-gitlink: do not get confused by overly long ifdef directive
The old pattern, when encountered "ifndef::git-shortlog,git-bar[]",
complained that "hortlog," (i.e., a substring that is up to 8 bytes
long, that comes before "git-bar[]") is not "linkgit:", which was a
nonsense.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
Documentation/lint-gitlink.perl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/lint-gitlink.perl b/Documentation/lint-gitlink.perl
index f183a18df2..91621f9db1 100755
--- a/Documentation/lint-gitlink.perl
+++ b/Documentation/lint-gitlink.perl
@@ -41,7 +41,7 @@ sub report {
@ARGV = $to_check;
while (<>) {
my $line = $_;
- while ($line =~ m/(.{,8})((git[-a-z]+|scalar)\[(\d)*\])/g) {
+ while ($line =~ m/([a-z]{,8}:+)((git[-a-z]+|scalar)\[(\d)*\])/g) {
my $pos = pos $line;
my ($macro, $target, $page, $section) = ($1, $2, $3, $4);
if ( $macro ne "linkgit:" && $macro !~ "ifn?def::" && $macro ne "endif::" ) {
--
2.53.0-rc0-249-g60c15f3eb8
next prev parent reply other threads:[~2026-01-20 23:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 1:47 [PATCH] replay: drop rev-list formatting options from manual D. Ben Knoble
2026-01-20 2:19 ` Junio C Hamano
2026-01-20 14:04 ` D. Ben Knoble
2026-01-20 15:37 ` Junio C Hamano
2026-01-20 21:49 ` Junio C Hamano
2026-01-20 23:11 ` Junio C Hamano [this message]
2026-01-21 13:27 ` Jean-Noël Avila
2026-01-21 16:26 ` Junio C Hamano
2026-01-21 20:03 ` D. Ben Knoble
2026-01-27 18:48 ` D. Ben Knoble
2026-01-20 14:05 ` [PATCH v2] " D. Ben Knoble
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy0lrx4l2.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=ben.knoble+github@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=code@khaugsbakk.name \
--cc=git@vger.kernel.org \
--cc=jn.avila@free.fr \
--cc=newren@gmail.com \
--cc=sandals@crustytoothpaste.net \
--cc=sorganov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.