All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>
Cc: "Josh Soref" <gitgitgadget@gmail.com>,
	 git@vger.kernel.org,  "Stefan Rieche" <stefanrieche@gmail.com>
Subject: Re: [PATCH] docs(git-pull.adoc): fix man page typo
Date: Fri, 28 Nov 2025 08:43:04 -0800	[thread overview]
Message-ID: <xmqqy0nqhzvr.fsf@gitster.g> (raw)
In-Reply-To: <f66c3b5a-6126-4fec-9c13-e4cdd3043fa0@app.fastmail.com> (Kristoffer Haugsbakk's message of "Fri, 28 Nov 2025 14:34:39 +0100")

"Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> writes:

> Nice fix.
>
>> docs(git-pull.adoc): fix man page typo
>
> Correct, you need an “area” in front of the message. But if you want
> something like “docs” it would be more typical/conventional with
> something like this:
>
>     doc: pull:
>
> or:
>
>     doc: git-pull:

or

	doc: fix typo in git-pull.adoc

>> Fix typo in man page from "git --rebase abort"
>> to "git rebase --abort"
>>
>> Signed-off-by: Stefan Rieche <stefanrieche@gmail.com>
>
> The `From:` (author) and signoff line should match. See `real-name` in
> `Documentation/SubmittingPatches`. Either a pseudonym or real/preferred
> name. But it looks like you want to use your real name.
>
> I see on the PR that you have used `snowdroppe <stefanrieche@gmail.com>`
> as the author on the commit. You can change your config for the project
> to use the same name and email as the signoff line. Then
>
>     git commit --amend --reset-author
>
> And force push to the branch on the remote.

Great.  Which would mean that the in-body From: line early in the
message will also say Stefan Rieche, not snowdroppe.

Thanks for a review.

  reply	other threads:[~2025-11-28 16:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-28 13:16 [PATCH] docs(git-pull.adoc): fix man page typo Stefan Rieche via GitGitGadget
2025-11-28 13:34 ` Kristoffer Haugsbakk
2025-11-28 16:43   ` Junio C Hamano [this message]
2025-11-28 14:25 ` [PATCH v2] doc: git-pull: fix typo in command Stefan Rieche via GitGitGadget
2025-12-02 23:49   ` [PATCH v3] doc: fix typo in git-pull.adoc Stefan Rieche via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqy0nqhzvr.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=kristofferhaugsbakk@fastmail.com \
    --cc=stefanrieche@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.