All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Abhijeet Sonar <abhijeet.nkt@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] environment: fix typo: 'setup_git_directory_gently'
Date: Fri, 18 Apr 2025 14:04:31 -0700	[thread overview]
Message-ID: <xmqqy0vx9o68.fsf@gitster.g> (raw)
In-Reply-To: <20250418185855.52950-1-abhijeet.nkt@gmaiil.com> (Abhijeet Sonar's message of "Sat, 19 Apr 2025 00:28:48 +0530")

Abhijeet Sonar <abhijeet.nkt@gmail.com> writes:

> From: Abhijeet Sonar <abhijeet.nkt@gmail.com>
>
> Above the declaration of git_work_tree_cfg, we have:
>
>   /* This is set by setup_git_dir_gently() and/or git_default_config() */
>   char *git_work_tree_cfg;
>
> It can be verified that there is no function called
> 'setup_git_dir_gently' by running grep on the codebase:
>
>   $ grep -R setup_git_dir_gently .
>   ./environment.c:/* This is set by setup_git_dir_gently() and/or git_default_config() */
>
> The comment, introduced in e90fdc39b6 (Clean up work-tree handling), is
> the only occurrence of the name 'setup_git_dir_gently'.
>
> It probably meant 'setup_git_directory_gently' as that is a name of a
> real function in setup.c. Correct it.
>
> Signed-off-by: Abhijeet Sonar <abhijeet.nkt@gmail.com>
> ---
>  environment.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Will queue.  Thanks for a well-written patch.

> diff --git a/environment.c b/environment.c
> index 3c32367c28..970a407753 100644
> --- a/environment.c
> +++ b/environment.c
> @@ -106,7 +106,7 @@ int auto_comment_line_char;
>  /* Parallel index stat data preload? */
>  int core_preload_index = 1;
>  
> -/* This is set by setup_git_dir_gently() and/or git_default_config() */
> +/* This is set by setup_git_directory_gently() and/or git_default_config() */
>  char *git_work_tree_cfg;
>  
>  /*

      reply	other threads:[~2025-04-18 21:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-18 18:58 [PATCH] environment: fix typo: 'setup_git_directory_gently' Abhijeet Sonar
2025-04-18 21:04 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqy0vx9o68.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=abhijeet.nkt@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.