From: Junio C Hamano <gitster@pobox.com>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: Ayush Chandekar <ayu.chandekar@gmail.com>,
git@vger.kernel.org, ps@pks.im, shejialuo@gmail.com
Subject: Re: [GSOC PATCH v2 2/2] attr: use `repo_settings_get_attributesfile_path()` and update callers
Date: Mon, 10 Mar 2025 16:08:24 -0700 [thread overview]
Message-ID: <xmqqy0xc4h7b.fsf@gitster.g> (raw)
In-Reply-To: <CAOLa=ZT=zGTF2DLEy9VjXhcUN3wEi7_R=8O6nV-TtBXKT=ENXg@mail.gmail.com> (Karthik Nayak's message of "Mon, 10 Mar 2025 14:17:06 -0700")
Karthik Nayak <karthik.188@gmail.com> writes:
> Ayush Chandekar <ayu.chandekar@gmail.com> writes:
>
>> Update attribute-related functions to retrieve the "core.attributesfile"
>> configuration via the new repository-scoped accessor
>> `repo_settings_get_attributesfile_path()`. This improves behaviour in
>> multi-repository contexts and aligns with the goal of minimizing
>> reliance on global state.
>>
>
> We should also talk about the modifications made to pass around the
> repository struct.
Yes. We first should justify if it makes sense to cram attribute
set into the repository object and pass it around in the first
place. Many index-state related functions do not pass repository
around because they work on index-state, so index-state is passed
around instead. Perhaps the attribute subsystem should be the same
way, in that their globals should belong to its own abstraction that
is smaller scale than a repository object (it is permissible to have
such an attribute-set object know about which repository instance it
is related to, though).
next prev parent reply other threads:[~2025-03-10 23:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-09 15:33 [PATCH] environment: move access to "core.attributesfile" into repo settings Ayush Chandekar
2025-03-10 7:05 ` Patrick Steinhardt
2025-03-10 9:07 ` Ayush Chandekar
2025-03-10 16:16 ` Junio C Hamano
2025-03-10 17:21 ` Ayush Chandekar
2025-03-10 19:25 ` Junio C Hamano
2025-03-10 15:10 ` [GSOC PATCH v2 0/2] Stop depending on `the_repository` for core.attributesfile Ayush Chandekar
2025-03-10 15:10 ` [GSOC PATCH v2 1/2] environment: move access to "core.attributesfile" into repo settings Ayush Chandekar
2025-03-10 21:11 ` Karthik Nayak
2025-03-10 15:10 ` [GSOC PATCH v2 2/2] attr: use `repo_settings_get_attributesfile_path()` and update callers Ayush Chandekar
2025-03-10 21:17 ` Karthik Nayak
2025-03-10 23:08 ` Junio C Hamano [this message]
2025-03-11 17:41 ` Ayush Chandekar
2025-03-11 14:39 ` shejialuo
2025-03-11 17:03 ` Junio C Hamano
2025-03-11 17:20 ` Ayush Chandekar
2025-12-08 20:11 ` Outreachy intern: Request for the completion of this series Olamide Caleb Bello
[not found] ` <CAE7as+Zka6J+du+V5zsHzc4eiH+Mzx=dQUnjuJz_Mhnk2RzOPA@mail.gmail.com>
2025-12-09 9:23 ` Bello Olamide
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy0xc4h7b.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=ayu.chandekar@gmail.com \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
--cc=ps@pks.im \
--cc=shejialuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.