All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Lucas Oshiro <lucasseikioshiro@gmail.com>
Cc: git@vger.kernel.org,  ps@pks.im
Subject: Re: [GSoC][PATCH v2] t7603: replace test -f by test_path_is_file
Date: Wed, 12 Feb 2025 10:04:57 -0800	[thread overview]
Message-ID: <xmqqy0ybt4xi.fsf@gitster.g> (raw)
In-Reply-To: <20250212172909.21257-1-lucasseikioshiro@gmail.com> (Lucas Oshiro's message of "Wed, 12 Feb 2025 14:28:16 -0300")

Lucas Oshiro <lucasseikioshiro@gmail.com> writes:

> `test_path_is_file` provides a better output when asserting whether a
> file exists. Replace the occurrences of `test -f` in t7603 by it,
> facilitating the trace of possible test fails.
>
> Signed-off-by: Lucas Oshiro <lucasseikioshiro@gmail.com>
> ---
>
> The only difference from v1 is a little typo, missing the t before the
> test name.


I think I fixed that while queueing the v1 iteration already.

You can check what happened to your patch by observing
https://git.kernel.org/pub/scm/git/git.git/log/?h=seen and
https://git.kernel.org/pub/scm/git/git.git/log/?h=next; other
hosting sites may have similar lists, but I find the one at k.org
the handiest to view.

Thanks.

  reply	other threads:[~2025-02-12 18:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-12 17:28 [GSoC][PATCH v2] t7603: replace test -f by test_path_is_file Lucas Oshiro
2025-02-12 18:04 ` Junio C Hamano [this message]
2025-02-12 18:40   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqy0ybt4xi.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=lucasseikioshiro@gmail.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.