From: Junio C Hamano <gitster@pobox.com>
To: karthik nayak <karthik.188@gmail.com>
Cc: shejialuo <shejialuo@gmail.com>,
git@vger.kernel.org, ps@pks.im,
Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH v2] builtin: allow passing custom data to sub-commands
Date: Wed, 27 Nov 2024 04:27:33 +0900 [thread overview]
Message-ID: <xmqqy115x0be.fsf@gitster.g> (raw)
In-Reply-To: <CAOLa=ZTeRUT6Ex5Pa-fM1i-QbTfnmDN=o=MU_N2VFeLQwbscgg@mail.gmail.com> (karthik nayak's message of "Tue, 26 Nov 2024 10:41:04 -0600")
karthik nayak <karthik.188@gmail.com> writes:
> Could you elaborate on why you think this is an over-optimization? We
> don't loose functionality with this, nor do we have to have add
> additional code to handle the typecasting to `struct repository *` if
> needed. But would definitely like to resolve anything I missed.
I do not know if it is an optimization, but if you know it is of a
specific type, casting back and force with "void *" loses type
safety, no?
next prev parent reply other threads:[~2024-11-26 19:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 14:55 [PATCH] builtin: pass repository to sub commands Karthik Nayak
2024-11-26 8:46 ` Christian Couder
2024-11-26 9:50 ` karthik nayak
2024-11-26 8:56 ` Patrick Steinhardt
2024-11-26 9:56 ` karthik nayak
2024-11-26 19:26 ` Junio C Hamano
2024-11-26 11:19 ` [PATCH v2] builtin: allow passing custom data to sub-commands Karthik Nayak
2024-11-26 11:57 ` shejialuo
2024-11-26 16:41 ` karthik nayak
2024-11-26 19:27 ` Junio C Hamano [this message]
2024-11-27 9:15 ` karthik nayak
2024-11-27 12:23 ` karthik nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy115x0be.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
--cc=ps@pks.im \
--cc=shejialuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.