From: Junio C Hamano <gitster@pobox.com>
To: Phil Hord <phil.hord@gmail.com>
Cc: git@vger.kernel.org, congdanhqx@gmail.com, plavarre@purestorage.com
Subject: Re: [PATCH] date.c: allow ISO 8601 reduced precision times
Date: Mon, 09 Jan 2023 18:16:15 +0900 [thread overview]
Message-ID: <xmqqy1qct6e8.fsf@gitster.g> (raw)
In-Reply-To: <xmqqbkn8um9q.fsf@gitster.g> (Junio C. Hamano's message of "Mon, 09 Jan 2023 17:48:01 +0900")
Junio C Hamano <gitster@pobox.com> writes:
> Phil Hord <phil.hord@gmail.com> writes:
>
>> Do you have any suggestions about how I can better alleviate your
>> concerns? I don't think there are real regressions here and I tried
>> to explain why.
>
> Other than "including it in a released version and waiting for
> people to scream", I do not think there is. The "next" branch was
> meant to be a test ground for these new features by letting
> volunteer users to use it in their everyday development, and the
> hope was that we can catch regressions by cooking risky topics
> longer than usual in there, but we haven't been very successful, I
> have to say.
>
> Thanks. Let's queue it and see what happens.
Actually, let's not queue it as-is, because it seems to break many
tests for me. I won't have time to take further look myself before
later in the week when I come back online again, though.
Test Summary Report
-------------------
t4255-am-submodule.sh (Wstat: 256 (exited 1) Tests: 33 Failed: 22)
Failed tests: 1-6, 11-13, 15-20, 25-27, 30-33
Non-zero exit status: 1
t4150-am.sh (Wstat: 256 (exited 1) Tests: 87 Failed: 62)
Failed tests: 3, 5-7, 11-13, 15-16, 18-22, 24-25, 27-32
34-36, 38-46, 48, 50-52, 54, 57-61, 63-65
67-77, 82-85
Non-zero exit status: 1
t4014-format-patch.sh (Wstat: 256 (exited 1) Tests: 193 Failed: 20)
Failed tests: 6-7, 10, 141-157
Non-zero exit status: 1
t7512-status-help.sh (Wstat: 256 (exited 1) Tests: 44 Failed: 1)
Failed test: 26
Non-zero exit status: 1
t3901-i18n-patch.sh (Wstat: 256 (exited 1) Tests: 20 Failed: 5)
Failed tests: 16-20
Non-zero exit status: 1
t4151-am-abort.sh (Wstat: 256 (exited 1) Tests: 20 Failed: 7)
Failed tests: 2-3, 5-6, 15, 19-20
Non-zero exit status: 1
t4153-am-resume-override-opts.sh (Wstat: 256 (exited 1) Tests: 5 Failed: 2)
Failed tests: 3-4
Non-zero exit status: 1
t5607-clone-bundle.sh (Wstat: 256 (exited 1) Tests: 14 Failed: 1)
Failed test: 3
Non-zero exit status: 1
t4152-am-subjects.sh (Wstat: 256 (exited 1) Tests: 13 Failed: 9)
Failed tests: 5-13
Non-zero exit status: 1
t4253-am-keep-cr-dos.sh (Wstat: 256 (exited 1) Tests: 7 Failed: 4)
Failed tests: 3-4, 6-7
Non-zero exit status: 1
t4257-am-interactive.sh (Wstat: 256 (exited 1) Tests: 4 Failed: 3)
Failed tests: 2-4
Non-zero exit status: 1
t4258-am-quoted-cr.sh (Wstat: 256 (exited 1) Tests: 4 Failed: 2)
Failed tests: 3-4
Non-zero exit status: 1
t4254-am-corrupt.sh (Wstat: 256 (exited 1) Tests: 4 Failed: 1)
Failed test: 3
Non-zero exit status: 1
t0023-crlf-am.sh (Wstat: 256 (exited 1) Tests: 2 Failed: 1)
Failed test: 2
Non-zero exit status: 1
t4256-am-format-flowed.sh (Wstat: 256 (exited 1) Tests: 2 Failed: 1)
Failed test: 2
Non-zero exit status: 1
Files=987, Tests=28346, 137 wallclock secs (12.84 usr 4.19 sys + 799.53 cusr 1017.07 csys = 1833.63 CPU)
Result: FAIL
gmake[1]: *** [Makefile:62: prove] Error 1
gmake[1]: Leaving directory '/home/gitster/w/buildfarm/seen/t'
gmake: *** [Makefile:3196: test] Error 2
rmdir: failed to remove '/dev/shm/testpen.2086794': Directory not empty
next prev parent reply other threads:[~2023-01-09 9:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 3:36 [PATCH] date.c: allow ISO 8601 reduced precision times Phil Hord
2022-12-16 4:23 ` Junio C Hamano
2022-12-16 18:38 ` Phil Hord
2023-01-09 6:41 ` Phil Hord
2023-01-09 8:48 ` Junio C Hamano
2023-01-09 9:16 ` Junio C Hamano [this message]
2023-01-09 18:30 ` Phil Hord
2023-01-09 11:29 ` [PATCH] fixup! " Đoàn Trần Công Danh
2023-01-09 12:29 ` [PATCH] date.c: limit less precision ISO-8601 with its marker Đoàn Trần Công Danh
2023-01-09 18:57 ` Phil Hord
2023-01-11 0:10 ` [PATCH v2] date.c: allow ISO 8601 reduced precision times Đoàn Trần Công Danh
2023-01-13 19:50 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy1qct6e8.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
--cc=phil.hord@gmail.com \
--cc=plavarre@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.