All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "nsengaw4c via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, nsengaw4c <nsengiyumvawilberforce@gmail.com>
Subject: Re: [PATCH] [OUTREACHY] t1002: modernize outdated conditional
Date: Thu, 13 Oct 2022 22:05:57 -0700	[thread overview]
Message-ID: <xmqqy1tjatai.fsf@gitster.g> (raw)
In-Reply-To: <pull.1362.git.git.1665713184304.gitgitgadget@gmail.com> (nsengaw4c via GitGitGadget's message of "Fri, 14 Oct 2022 02:06:24 +0000")

"nsengaw4c via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: wilberforce <nsengiyumvawilberforce@gmail.com>

This name must match ...

> Tests in this script use an unusual and hard to reason about
> conditional construct
>
>     if expression; then false; else :; fi
>
> Change them to use more idiomatic construct:
>
>     ! expression
>
> Cc: Christian Couder  <christian.couder@gmail.com>
> Cc: Hariom Verma <hariom18599@gmail.com>
> Signed-off-by: Nsengiyumva  wilberfore <nsengiyumvawilberforce@gmail.com>

... the name you sign-off your work with.

> -     if read_tree_u_must_succeed -m -u $treeH $treeM; then false; else :; fi'
> +     ! read_tree_u_must_succeed -m -u $treeH $treeM'

OK.


  reply	other threads:[~2022-10-14  5:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-14  2:06 [PATCH] [OUTREACHY] t1002: modernize outdated conditional nsengaw4c via GitGitGadget
2022-10-14  5:05 ` Junio C Hamano [this message]
2022-10-14  7:47 ` [PATCH v2] " nsengaw4c via GitGitGadget
2022-10-14  8:01   ` [PATCH v3] " nsengaw4c via GitGitGadget
2022-10-14 16:15     ` Junio C Hamano
2022-10-14 16:21       ` Derrick Stolee
2022-10-14 16:58         ` Eric Sunshine
2022-10-14 17:54           ` Derrick Stolee
2022-10-14 18:57             ` Junio C Hamano
2022-10-14 19:06           ` Junio C Hamano
2022-10-14 19:14             ` Eric Sunshine
2022-10-14 20:41               ` Junio C Hamano
2022-10-14 20:19             ` Philip Oakley
2022-10-14 20:42               ` Junio C Hamano
2022-10-14 18:28     ` [PATCH v4] " nsengaw4c via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqy1tjatai.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=nsengiyumvawilberforce@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.