All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "René Scharfe" <l.s.r@web.de>, "Git List" <git@vger.kernel.org>,
	"Jiang Xin" <zhiyou.jx@alibaba-inc.com>
Subject: Re: [PATCH] t/lib-httpd: pass LANG to Apache
Date: Thu, 06 Oct 2022 09:20:51 -0700	[thread overview]
Message-ID: <xmqqy1tsnct8.fsf@gitster.g> (raw)
In-Reply-To: <Yz31Lv+97z9p/0TK@coredump.intra.peff.net> (Jeff King's message of "Wed, 5 Oct 2022 17:20:46 -0400")

Jeff King <peff@peff.net> writes:

>> Shouldn't we be doing the same here?
>
> I think setting both probably is overkill. But if we are going to set
> one, the important one is LC_ALL. It overrides specific LC_* variables,
> which in turn override LANG. So just setting LANG would get confused if
> LC_MESSAGES were set, for example.
>
> That said, there probably is no downside to passing through both, so we
> might as well do so.

Yup.  I suspect that the habit dates back to before LC_* was widespread
and some platforms needed LANG.  On modern systems that understand i18n
and do not need to set NO_GETTEXT, forcing LC_ALL should be sufficient.

> Other than that, the patch is obviously the right thing to be doing. I'm
> surprised it took this long for it to be a problem. ;)

Thanks.

      parent reply	other threads:[~2022-10-06 16:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-04 17:42 [PATCH] t/lib-httpd: pass LANG to Apache René Scharfe
2022-10-05 19:50 ` Junio C Hamano
2022-10-05 21:20   ` Jeff King
2022-10-06 15:33     ` [PATCH v2] t/lib-httpd: pass LANG and LC_ALL " René Scharfe
2022-10-06 16:20     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqy1tsnct8.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=l.s.r@web.de \
    --cc=peff@peff.net \
    --cc=zhiyou.jx@alibaba-inc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.