From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: me@ttaylorr.com, gitgitgadget@gmail.com, git@vger.kernel.org,
tao@klerks.biz
Subject: Re: [PATCH] Remove warning that repack only works on non-promisor packfiles
Date: Fri, 04 Jun 2021 10:03:43 +0900 [thread overview]
Message-ID: <xmqqy2bq30gg.fsf@gitster.g> (raw)
In-Reply-To: <20210603213558.453725-1-jonathantanmy@google.com> (Jonathan Tan's message of "Thu, 3 Jun 2021 14:35:58 -0700")
Jonathan Tan <jonathantanmy@google.com> writes:
>> On Wed, Jun 02, 2021 at 11:47:26AM +0000, Tao Klerks via GitGitGadget wrote:
>> > From: Tao Klerks <tao@klerks.biz>
>> >
>> > The git-repack doc clearly states that it *does* operate on promisor
>> > packfiles (in a separate partition), with "-a" specified. Presumably
>> > the statements here are outdated, as they feature from the first doc
>> > in 2017 (and the repack support was added in 2018)
>>
>> Yeah, this all originally comes from Jeff H.'s design document in
>> 637fc4467e (partial-clone: design doc, 2017-12-14), but probably should
>> have been updated in 5d19e8138d (repack: repack promisor objects if -a
>> or -A is set, 2018-08-08).
>>
>> This looks good to me, but I'll add Jonathan Tan to the CC list to
>> double check.
>>
>> Reviewed-by: Taylor Blau <me@ttaylorr.com>
>
> Thanks, Taylor. Yes, the patch is correct.
Thanks, all of you. Will queue.
prev parent reply other threads:[~2021-06-04 1:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 11:47 [PATCH] Remove warning that repack only works on non-promisor packfiles Tao Klerks via GitGitGadget
2021-06-02 19:45 ` Taylor Blau
2021-06-03 21:35 ` Jonathan Tan
2021-06-04 1:03 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy2bq30gg.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=jonathantanmy@google.com \
--cc=me@ttaylorr.com \
--cc=tao@klerks.biz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.