From: Junio C Hamano <gitster@pobox.com>
To: Elijah Newren <newren@gmail.com>
Cc: Luke Shumaker <lukeshu@lukeshu.com>,
Git Mailing List <git@vger.kernel.org>,
Luke Shumaker <lukeshu@datawire.io>, Jeff King <peff@peff.net>
Subject: Re: [RFC PATCH] fast-export, fast-import: Let tags specify an internal name
Date: Wed, 21 Apr 2021 11:54:52 -0700 [thread overview]
Message-ID: <xmqqy2dbxybn.fsf@gitster.g> (raw)
In-Reply-To: <CABPp-BF-rHnxvz0sAFAujXkiNwSjtpRQA4uvxT=a3z8v_sYbAA@mail.gmail.com> (Elijah Newren's message of "Wed, 21 Apr 2021 11:41:57 -0700")
Elijah Newren <newren@gmail.com> writes:
> On Tue, Apr 20, 2021 at 2:40 PM Junio C Hamano <gitster@pobox.com> wrote:
>> ...
>> +The `<refname>` is prefixed with `refs/tags/` when stored
>> in Git, so importing the CVS branch symbol `RELENG-1_0-FINAL` would
>> -use just `RELENG-1_0-FINAL` for `<name>`, and fast-import will write the
>> +use just `RELENG-1_0-FINAL` for `<refname>`, and fast-import will write the
>> corresponding ref as `refs/tags/RELENG-1_0-FINAL`.
>
> Going on a slight tangent since you didn't introduce this, but since
> you're modifying this exact documentation...
>
> I hate the assumed "refs/tags/" prefix. Especially since ...
> ... The special casing reminds me of the ref-updated hook in
> gerrit
Gerrit and fast-import? What is common is Shawn, perhaps ;-)?
> broken given the fact that the name inside the tag didn't match the
> name of the actual ref. (To be honest, though, I was never sure why
> the name of the tag was recorded inside the tag itself.)
The name of the tag and the name of the object has to be together
for a signature over it to have any meaning, no?
next prev parent reply other threads:[~2021-04-21 18:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 19:05 [RFC PATCH] fast-export, fast-import: Let tags specify an internal name Luke Shumaker
2021-04-20 21:40 ` Junio C Hamano
2021-04-21 8:18 ` Ævar Arnfjörð Bjarmason
2021-04-21 16:17 ` Luke Shumaker
2021-04-21 16:59 ` Junio C Hamano
2021-04-21 18:34 ` Elijah Newren
2021-04-21 18:48 ` Luke Shumaker
2021-04-21 19:24 ` Elijah Newren
2021-04-22 8:41 ` Ævar Arnfjörð Bjarmason
2021-04-21 18:41 ` Elijah Newren
2021-04-21 18:54 ` Junio C Hamano [this message]
2021-04-21 19:32 ` Elijah Newren
2021-04-22 8:54 ` Ævar Arnfjörð Bjarmason
2021-04-22 19:37 ` Elijah Newren
2021-04-21 8:03 ` Ævar Arnfjörð Bjarmason
2021-04-21 16:34 ` Luke Shumaker
2021-04-21 17:26 ` Luke Shumaker
2021-04-21 18:26 ` Elijah Newren
2021-04-21 17:48 ` Junio C Hamano
2021-04-23 16:47 ` Luke Shumaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy2dbxybn.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=lukeshu@datawire.io \
--cc=lukeshu@lukeshu.com \
--cc=newren@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.