From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Jan “Khardix” Staněk" <khardix@gmail.com>, git@vger.kernel.org
Subject: Re: git-send-email: smtpserver in $HOME
Date: Tue, 16 Feb 2021 11:16:18 -0800 [thread overview]
Message-ID: <xmqqy2fnq0vx.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <YCwXf1CA0Xyw/B88@coredump.intra.peff.net> (Jeff King's message of "Tue, 16 Feb 2021 14:05:35 -0500")
Jeff King <peff@peff.net> writes:
> Sure, but you cannot say "does it refer to a local file" for a
> non-absolute path.
Hmph, why not? I would expect that this would work as a valid way
$ git send-email --smtp-server=./my-phoney-smtp
to test a server substitute (perhaps for testing). The only reason
why it does not is because file_name_is_absolute() check would not
like it.
> And that is the source of the problem, IMHO: there is
> no way to signal "this is a command I expect to be executed" except by
> using an absolute path.
Yes.
> Or do you mean that we should see if $smtp_server exists in the PATH,
> and if so prefer it over a network hostname?
We can certainly go in that direction, too. A new --smtp-program option
would be a cleaner way to solve it, though, as you said elsewhere.
next prev parent reply other threads:[~2021-02-16 19:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 14:07 git-send-email: smtpserver in $HOME Jan “Khardix” Staněk
2021-02-16 2:14 ` Junio C Hamano
2021-02-16 12:49 ` Jan “Khardix” Staněk
2021-02-16 18:53 ` Junio C Hamano
2021-02-16 22:14 ` Jan “Khardix” Staněk
2021-02-18 10:18 ` Chris Torek
2021-02-18 12:57 ` Andreas Schwab
2021-02-16 15:45 ` Jeff King
2021-02-16 18:57 ` Junio C Hamano
2021-02-16 19:05 ` Jeff King
2021-02-16 19:16 ` Junio C Hamano [this message]
2021-02-16 19:23 ` Jeff King
2021-02-16 22:31 ` Jan “Khardix” Staněk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy2fnq0vx.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=khardix@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.