All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Denton Liu <liu.denton@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] checkout: learn to respect checkout.guess
Date: Wed, 07 Oct 2020 09:47:41 -0700	[thread overview]
Message-ID: <xmqqy2ki2daq.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <2678680a08e025e9652c6769501dbc604560394b.1602047333.git.liu.denton@gmail.com> (Denton Liu's message of "Tue, 6 Oct 2020 22:09:09 -0700")

Denton Liu <liu.denton@gmail.com> writes:

> diff --git a/Documentation/git-checkout.txt b/Documentation/git-checkout.txt
> index afa5c11fd3..28f656d04e 100644
> --- a/Documentation/git-checkout.txt
> +++ b/Documentation/git-checkout.txt
> @@ -193,6 +193,9 @@ branches from there if `<branch>` is ambiguous but exists on the
>  linkgit:git-config[1].
>  +
>  Use `--no-guess` to disable this.
> ++
> +The default behavior can be set via the `checkout.guess` configuration
> +variable.
>  
>  -l::
>  	Create the new branch's reflog; see linkgit:git-branch[1] for
> diff --git a/Documentation/git-switch.txt b/Documentation/git-switch.txt
> index 3759c3a265..5c438cd505 100644
> --- a/Documentation/git-switch.txt
> +++ b/Documentation/git-switch.txt
> @@ -103,6 +103,9 @@ ambiguous but exists on the 'origin' remote. See also
>  `checkout.defaultRemote` in linkgit:git-config[1].
>  +
>  `--guess` is the default behavior. Use `--no-guess` to disable it.
> ++
> +The default behavior can be set via the `checkout.guess` configuration
> +variable.

Contrasting the above two, one cannot help but notice that it is
totally unclear how "git checkout" that is not explicitly told by
command line or configuration behaves.  Perhaps "`--guess` is the
default behaviour." needs to be transplated from the description
for "git switch" to clarify?

This is not a new issue, but is made stand out even more prominently
due to the addition.

Thanks.

  reply	other threads:[~2020-10-07 16:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-04 11:18 [PATCH 0/2] checkout: learn the checkout.guess config variable Denton Liu
2020-10-04 11:18 ` [PATCH 1/2] Documentation/config/checkout: replace sq with backticks Denton Liu
2020-10-04 11:18 ` [PATCH 2/2] checkout: learn to respect checkout.guess Denton Liu
2020-10-04 17:46   ` Junio C Hamano
2020-10-06  8:07     ` Denton Liu
2020-10-06 18:41       ` Junio C Hamano
2020-10-06 19:31         ` Johannes Schindelin
2020-10-07  5:09 ` [PATCH v2 0/2] checkout: learn the checkout.guess config variable Denton Liu
2020-10-07  5:09   ` [PATCH v2 1/2] Documentation/config/checkout: replace sq with backticks Denton Liu
2020-10-07  5:09   ` [PATCH v2 2/2] checkout: learn to respect checkout.guess Denton Liu
2020-10-07 16:47     ` Junio C Hamano [this message]
2020-10-08  5:48   ` [PATCH v3 0/2] checkout: learn the checkout.guess config variable Denton Liu
2020-10-08  5:48     ` [PATCH v3 1/2] Documentation/config/checkout: replace sq with backticks Denton Liu
2020-10-08  5:48     ` [PATCH v3 2/2] checkout: learn to respect checkout.guess Denton Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqy2ki2daq.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=liu.denton@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.