From: Junio C Hamano <gitster@pobox.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Stefan Beller <sbeller@google.com>, git@vger.kernel.org
Subject: Re: [PATCH 00/11] Moving global state into the repository object (part 2)
Date: Wed, 28 Feb 2018 09:59:40 -0800 [thread overview]
Message-ID: <xmqqy3jdknar.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180228021530.GA20625@duynguyen.dek-tpc.internal> (Duy Nguyen's message of "Wed, 28 Feb 2018 09:15:30 +0700")
Duy Nguyen <pclouds@gmail.com> writes:
> Looking at the full-series diff though, it makes me wonder if we
> should keep prepare_packed_git() private (i.e. how we initialize the
> object store, packfile included, is a private matter). How about
> something like this on top?
Yup, that looks cleaner.
next prev parent reply other threads:[~2018-02-28 17:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 1:05 [PATCH 00/11] Moving global state into the repository object (part 2) Stefan Beller
2018-02-28 1:05 ` [PATCH 01/11] packfile: allow prepare_packed_git_mru to handle arbitrary repositories Stefan Beller
2018-02-28 1:05 ` [PATCH 02/11] packfile: allow rearrange_packed_git " Stefan Beller
2018-02-28 1:06 ` [PATCH 03/11] packfile: allow install_packed_git " Stefan Beller
2018-02-28 14:38 ` Derrick Stolee
2018-02-28 1:06 ` [PATCH 04/11] packfile: add repository argument to prepare_packed_git_one Stefan Beller
2018-02-28 1:06 ` [PATCH 05/11] packfile: add repository argument to prepare_packed_git Stefan Beller
2018-02-28 1:06 ` [PATCH 06/11] packfile: add repository argument to reprepare_packed_git Stefan Beller
2018-02-28 1:06 ` [PATCH 07/11] packfile: allow prepare_packed_git_one to handle arbitrary repositories Stefan Beller
2018-02-28 1:06 ` [PATCH 08/11] packfile: allow prepare_packed_git " Stefan Beller
2018-02-28 1:06 ` [PATCH 09/11] packfile: allow reprepare_packed_git " Stefan Beller
2018-02-28 1:06 ` [PATCH 10/11] packfile: add repository argument to find_pack_entry Stefan Beller
2018-02-28 1:06 ` [PATCH 11/11] packfile: allow find_pack_entry to handle arbitrary repositories Stefan Beller
2018-02-28 2:15 ` [PATCH 00/11] Moving global state into the repository object (part 2) Duy Nguyen
2018-02-28 14:47 ` Derrick Stolee
2018-02-28 17:59 ` Junio C Hamano [this message]
2018-02-28 18:59 ` Stefan Beller
2018-02-28 19:09 ` Junio C Hamano
2018-02-28 17:57 ` Junio C Hamano
2018-02-28 18:56 ` Stefan Beller
2018-02-28 19:19 ` Jonathan Nieder
2018-02-28 19:02 ` Junio C Hamano
2018-02-28 19:09 ` Stefan Beller
-- strict thread matches above, loose matches on Subject: below --
2018-03-03 2:54 Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqy3jdknar.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.